Skip to content

Add the seidroid review v2 contract and its tests - #128

Closed
masih wants to merge 1 commit into
mainfrom
masih/1793980951-seidroid-review-v2-skeleton
Closed

masih wants to merge 1 commit into
mainfrom
masih/1793980951-seidroid-review-v2-skeleton

Conversation

@masih

@masih masih commented Nov 6, 2026 •

Copy link
Copy Markdown
Collaborator

This starts seidroid review v2: the same seidroid review contract as seidroid-review.yml, run in pi on the GitHub runner instead of a long-lived omnigent session. It is built in .github/seidroid/review-v2/ beside v1 and changes nothing v1 uses. This first layer is the contract itself, ported from the v1 driver's internal/review package to TypeScript so the workflow, the pi extension and the publisher can share it and be pinned by a single uci ref.

ReviewSubmission is the schema of the submit_review tool that later layers register with pi, so the review arrives as validated arguments instead of a fenced JSON block that has to be parsed out of prose. standing keeps the driver's rules for turning a submission into the recorded decision and check conclusion: a blocker of any kind escalates to request_changes, a comment with nothing written down or a review with no diff line count is neutral, and an unaccepted pre-existing blocker withholds approval without failing the check. parseAccepted and acceptanceFor read the base branch's Accepted conditions the same way, and placeableFindings and buildThreadPlan keep the path checks, dedupe, nit gating, caps, and the refusal of thread ids that are not the review's own.

The tests port the driver's cases for these rules. Node 24 runs the TypeScript directly, so there is no build step, and the new seidroid-review-v2-test.yml typechecks and tests the package on changes to it.

@devin-ai-integration

Copy link
Copy Markdown
Contributor

I'll fix CI failures and address comments from users with write access that start with 'Devin'.

  • Disable automatic comment, CI, and merge conflict monitoring

@devin-ai-integration

Copy link
Copy Markdown
Contributor

Moved to sei-protocol/seidroid#1, where all of seidroid review v2 lives.

@devin-ai-integration
devin-ai-integration Bot deleted the masih/1793980951-seidroid-review-v2-skeleton branch November 6, 2026 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant