Repository navigation
Conversation
Contributor
|
I'll fix CI failures and address comments from users with write access that start with 'Devin'.
|
Contributor
|
Moved to sei-protocol/seidroid#1, where all of seidroid review v2 lives. |
devin-ai-integration
Bot
deleted the
masih/1793980951-seidroid-review-v2-skeleton
branch
November 6, 2026 16:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This starts seidroid review v2: the same seidroid review contract as
seidroid-review.yml, run in pi on the GitHub runner instead of a long-lived omnigent session. It is built in.github/seidroid/review-v2/beside v1 and changes nothing v1 uses. This first layer is the contract itself, ported from the v1 driver'sinternal/reviewpackage to TypeScript so the workflow, the pi extension and the publisher can share it and be pinned by a single uci ref.ReviewSubmissionis the schema of thesubmit_reviewtool that later layers register with pi, so the review arrives as validated arguments instead of a fenced JSON block that has to be parsed out of prose.standingkeeps the driver's rules for turning a submission into the recorded decision and check conclusion: a blocker of any kind escalates torequest_changes, a comment with nothing written down or a review with no diff line count is neutral, and an unaccepted pre-existing blocker withholds approval without failing the check.parseAcceptedandacceptanceForread the base branch's Accepted conditions the same way, andplaceableFindingsandbuildThreadPlankeep the path checks, dedupe, nit gating, caps, and the refusal of thread ids that are not the review's own.The tests port the driver's cases for these rules. Node 24 runs the TypeScript directly, so there is no build step, and the new
seidroid-review-v2-test.ymltypechecks and tests the package on changes to it.