Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! I think it would be great to add support for Caddy custom snippets. We discussed something similar in #680
The problem is that currently, we only have three places to import our configuration files:
caddyfile-global.d,caddyfile-server.d, orcaddyfile.d. However, none of these places allow for the creation of custom snippets. Snippets should be declared at the top level of the Caddyfile and before any common snippets like,php-app-common.This PR adds the import of the configuration files from the
caddyfile-snippets.ddirectory at the top of the Caddyfile. This allows us to use any of the snippets defined in that files anywhere we need them.What do you think? This would allow us to extend our server rules in a modular format without having to override the default configuration.