Repository navigation
Register self-host-native.config.ts with the CI selection - #52
Merged
Merged
Conversation
Fork commit f403815 added e2e/self-host-native.config.ts without listing it in suiteConfigs, so every selection failed with SelectionFailed. With it listed, the selection runs again and ci-selection.spec.ts goes from 20 failing scenarios to 4. The 4 that still fail check workflows (release-artifacts.yml, checks.yml) that neither this fork nor upstream's public export carries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the post-cutover upstream sync plan: fix the CI selection, which has failed on
v2since fork commitf403815c2.Cause
f403815c2(bundled Motel in its own workerd process) addede2e/self-host-native.config.tsbut didn't list it insuiteConfigsine2e/ci-selection.ts. So every run of the selection failed:Change
List the config in
suiteConfigs(one line).Verified
node e2e/ci-selection.tsruns again.bunx vitest run --config e2e/ci-selection.config.ts: before, 20 of 28 scenarios failed; after, 24 pass and 4 fail.release-artifacts.yml("Executor releases") orchecks.yml, that exists only in upstream's private repo. This fork has onlyfork-ci.yml, and upstream's public export ships no.github/workflowsat all, so these can't pass on either public tree. They're recorded in the upstream sync plan rather than changed here.bun run checkpasses.