Repository navigation
fix: restore app short-name lookup for older CLI clients (#71) - #74
Merged
Merged
Conversation
Self-host kept its narrowed catalog and skipped wire-revision lookup, so a CLI that sends @slug/label could not find @slug.executor.community/label. Resolve that short name inside the caller's catalog. Revision 1 and the public registry keep the upstream lookup. Co-authored-by: shuv <shuv1337@users.noreply.github.com>
This was referenced Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #71
After the upstream v2 sync, a self-host request that supplies the organization's narrowed catalog returned that catalog unchanged. A CLI released before publisher scopes states no wire revision and sends a listing's short name,
@slug/label, for the stored name@slug.executor.community/label. The public catalog already resolves that name. The organization catalog did not, so those clients could not list, read, or install the listing.Short names now resolve inside the caller's catalog, with the same rules as the public catalog. A listing the caller cannot see is not a candidate, and a name that two visible listings share is refused. Revision 1 still reads each name as stored, so current clients are unchanged. Removing a listing by a short name stays refused: a removal names no commit, and by the time it arrives the short name can select a different listing.
Tests
bun run typecheck: 9/9 projects, 0 errors.bun run lint: passed.bun run e2e:self-host --workers 1 --test-name 'short package name': failed. The revision-0 catalog returned the stored scoped name instead of the short name the client sent.bun run e2e:self-host --workers 1 --test-name 'Team registry publishes': passed (9.4s). This is the revision-1 organization catalog, source, and copy.