Repository navigation
Fix platform tags for libfaketime wheels - #95
Open
daniel-zullo-frequenz wants to merge 1 commit into
Open
daniel-zullo-frequenz wants to merge 1 commit into
daniel-zullo-frequenz wants to merge 1 commit into
Conversation
The universal wheel lets ARM64 pip install an x86-64 library that cannot be loaded. Platform tags let pip reject that wheel and use a compatible wheel or build from source instead. Keep the library beside its Python package and declare the build dependencies needed for macOS platform tags. Fixes simon-weber#94
Owner
|
Thanks! I'm traveling currently so it'll be a bit till I can look at this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The universal wheel contains an x86-64 library that ARM64 cannot load. Tag wheels for their build platform, while keeping
py3-nonecompatibility, so pip can choose a compatible wheel or build from source.Keep the library beside its Python package and declare the build dependencies needed for macOS platform tags. Source installs require
makeand a C compiler. Linux release wheels needauditwheelrepair before uploading to PyPI.Fixes #94