Repository navigation
fix(scripts): normalize Windows path separators in validation scripts - #9400
Open
sahooarnav2007-gif wants to merge 1 commit into
Open
sahooarnav2007-gif wants to merge 1 commit into
sahooarnav2007-gif wants to merge 1 commit into
Conversation
|
Someone is attempting to deploy a commit to the Sim Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
[Low impact] The PR appears safe to merge. SummaryThis PR makes path comparisons consistent on Windows in two validation scripts.
No actionable issues found. This review checked the code paths; it did not run the scripts on Windows. Reviews (1) · Last reviewed commit: "fix(scripts): normalize Windows path sep..." · Reviewed by Greptile |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Normalizes path separators in
scripts/check-tool-registry-boundary.tsandscripts/check-api-validation-contracts.tsto ensure consistent cross-platform execution on Windows environments.Problems Resolved:
check-tool-registry-boundary.ts:collectEntries()emitted relative paths with Windows backslashes (\), causing all 85 entries to fail comparison againstcheck-tool-registry-boundary.baseline.jsonas unbaselined/removed.check-api-validation-contracts.ts:INDIRECT_ZOD_ROUTES.has(relativePath)failed for all 55 exempted routes due to backslash paths, falsely reportingnon-Zod routes increased from 0 to 55. In addition,routeFamily()prefix stripping andisApiRouteHandler()/isClientHookFile()failed when comparing POSIX paths against Windows directory paths.Product update (if relevant)
N/A — Developer tooling and CI verification fix for Windows environments.
Type of Change
Testing
bun run check:tool-registry-boundaryon Windows: passes cleanly with all 85 entry graphs matching baseline.bun run check:api-validationon Windows: passes cleanly with 895/895 Zod-backed routes and 0 non-Zod routes.bunx biome check.Checklist
Screenshots/Videos