Skip to content

chore(tls): drop the CA distrust step from the Bun services now that Bun ships the blocklist - #9413

Merged
waleedlatif1 merged 1 commit into
stagingfrom
chore/drop-bun-ca-distrust
Oct 28, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
chore/drop-bun-ca-distrust

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Drop distrustCompromisedRoots() from the app and realtime entrypoints. Both images run Bun 1.4.4, which ships the upstream blocklist (crypto: update root certificates oven-sh/bun#46159), so the step removes nothing there: under Bun 1.4.4 it returns removed: [], while under 1.4.2 it removes emSign ECC Root CA - G3
  • Keep it in the Trigger.dev init. That runtime runs on Node, and the Trigger.dev platform picks the Node build, so we can't confirm it has tls: reject chains containing blocked public keys nodejs/node#66871; there the step is a no-op once Node has the fix and a safeguard until then
  • Update the tls-trust module doc to say which runtime still calls it

Type of Change

  • Chore

Testing

  • Ran distrustCompromisedRoots() under Bun 1.4.2 (removes the root) and 1.4.4 (removes nothing)
  • Realtime tsc --noEmit, Biome, comment hygiene, realtime prune-graph, and unused-exports checks pass; full lint, type-check, and audits run in CI

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Oct 28, 2026 4:54pm UTC

Request Review

@greptile-apps

greptile-apps Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] The PR appears safe to merge; no actionable issues were found.

Summary

Removes distrustCompromisedRoots() and its result logging from the app and realtime container entrypoints. Updates the shared helper’s documentation to identify Trigger.dev as its remaining caller.

  • The app and realtime services rely on Bun's built-in blocklist.

Reviews (1) · Last reviewed commit: "chore(tls): drop the CA distrust step fr..." · Reviewed by Greptile

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit b6b888a into staging Oct 28, 2026
62 checks passed
@waleedlatif1
waleedlatif1 deleted the chore/drop-bun-ca-distrust branch October 28, 2026 16:57

This branch was successfully deployed

1 active deployment
Preview — de7e9f06 Deployed Oct 28, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant