Repository navigation
chore(tls): drop the CA distrust step from the Bun services now that Bun ships the blocklist - #9413
Merged
Merged
Conversation
…Bun ships the blocklist
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
[Low impact] The PR appears safe to merge; no actionable issues were found. SummaryRemoves
Reviews (1) · Last reviewed commit: "chore(tls): drop the CA distrust step fr..." · Reviewed by Greptile |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
distrustCompromisedRoots()from the app and realtime entrypoints. Both images run Bun 1.4.4, which ships the upstream blocklist (crypto: update root certificates oven-sh/bun#46159), so the step removes nothing there: under Bun 1.4.4 it returnsremoved: [], while under 1.4.2 it removesemSign ECC Root CA - G3init. That runtime runs on Node, and the Trigger.dev platform picks the Node build, so we can't confirm it has tls: reject chains containing blocked public keys nodejs/node#66871; there the step is a no-op once Node has the fix and a safeguard until thentls-trustmodule doc to say which runtime still calls itType of Change
Testing
distrustCompromisedRoots()under Bun 1.4.2 (removes the root) and 1.4.4 (removes nothing)tsc --noEmit, Biome, comment hygiene, realtime prune-graph, and unused-exports checks pass; full lint, type-check, and audits run in CIChecklist
test-auditauthoring gate)