Repository navigation
fix(desktop): hold the GitHub credential check open while the e2e asserts its pending state - #9420
Merged
Conversation
…erts its pending state
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
[Low impact] This PR appears safe to merge. SummaryReplaces the GitHub credential check’s fixed delay with a response the test can hold open.
No actionable issues found. The desktop E2E suite was not run locally. Reviews (1) · Last reviewed commit: "fix(desktop): hold the GitHub credential..." · Reviewed by Greptile |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GitHub pendingistrueduring a fixed 500 ms delay on the credential check.expect.pollbacks off to 1 s, so it can notice the check request after the response is back and the flag isfalseagain — the long serial desktop release run lost that race on both attempts.finally) and asserts the verified credential andpending: falseas before. Same assertions, no timing window.Type of Change
Testing
biome checkon the changed specdesktop-e2efor this path; not run locallyChecklist
test-auditauthoring gate)