Skip to content

fix(desktop): hold the GitHub credential check open while the e2e asserts its pending state - #9420

Merged
waleedlatif1 merged 1 commit into
stagingfrom
fix/desktop-source-connect-pending-race
Oct 28, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
fix/desktop-source-connect-pending-race

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • The source-connect desktop e2e asserted GitHub pending is true during a fixed 500 ms delay on the credential check. expect.poll backs off to 1 s, so it can notice the check request after the response is back and the flag is false again — the long serial desktop release run lost that race on both attempts.
  • The fixture now holds the credential-check response until the test has seen the pending state, then releases it (in finally) and asserts the verified credential and pending: false as before. Same assertions, no timing window.

Type of Change

  • Bug fix

Testing

  • biome check on the changed spec
  • Desktop e2e (macOS) runs in CI via desktop-e2e for this path; not run locally

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Oct 28, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Building Building Preview Oct 28, 2026 8:57pm UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] This PR appears safe to merge.

Summary

Replaces the GitHub credential check’s fixed delay with a response the test can hold open.

  • The GitHub test sees pending before the credential check finishes.

No actionable issues found. The desktop E2E suite was not run locally.

Reviews (1) · Last reviewed commit: "fix(desktop): hold the GitHub credential..." · Reviewed by Greptile

@waleedlatif1
waleedlatif1 merged commit 7f72c6d into staging Oct 28, 2026
35 of 36 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/desktop-source-connect-pending-race branch October 28, 2026 21:01

This branch was successfully deployed

1 active deployment
Preview — 5c9bf11b Deployed Oct 28, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant