Repository navigation
chore(deps): replace deprecated OpenTelemetry trace SDK packages with @opentelemetry/sdk-trace - #9421
Merged
Merged
Conversation
… @opentelemetry/sdk-trace @opentelemetry/sdk-trace-base and @opentelemetry/sdk-trace-node are deprecated in favor of @opentelemetry/sdk-trace. Import the trace SDK from @opentelemetry/sdk-trace 2.10.0, matching the installed core and resources 2.10.0 and staying on @opentelemetry/api 1.9.x so the global API stays shared with the Trigger.dev runtime. BatchSpanProcessor and SimpleSpanProcessor take an options object with the exporter, and BasicTracerProvider is TracerProvider. Every batch option is set explicitly, so the dropped OTEL_BSP_* environment fallbacks change nothing.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
 [Low impact] The PR appears safe to merge; no actionable defects were found. SummaryReplaces the app’s direct dependencies on the deprecated trace packages with
No actionable issues were found. Tests were not run, and installed package sources were unavailable for checking exact exports. Reviews (1) · Last reviewed commit: "chore(deps): replace deprecated OpenTele..." · Reviewed by Greptile |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@opentelemetry/sdk-trace-baseand@opentelemetry/sdk-trace-nodedeps with@opentelemetry/sdk-trace2.10.0 (same version as our installed core/resources; it is whatsdk-trace-base2.10.0 already wraps, so there is still a single copy)BatchSpanProcessor/SimpleSpanProcessortake{ exporter, ... }, andBasicTracerProviderisTracerProviderin the new packageOTEL_BSP_*env fallbacks the old wrapper read change nothing@opentelemetry/api1.9.x on purpose: OTel JS 3 requires api 1.10, while@trigger.dev/corepins api 1.9.1, and api 1.10 ignores a global registered by 1.9, so spans and logs inside Trigger runs would go to a no-op tracer. The 3.x jump waits for Trigger.dev supportType of Change
Testing
route.test.ts,timing.test.ts,headless.test.ts,start.test.ts(32 tests) pass locallycheck:audits, the full suite andreplay-budget.integration.tsrun in CIChecklist
test-auditauthoring gate)