Repository navigation
chore(deps): dependency hygiene cleanup - #9422
Merged
Merged
Conversation
- Bump the qs (6.16.1) and fast-uri (3.1.9) override pins off the vulnerable releases. - Drop the artillery devDependency; the load:workflow scripts run it through bunx. - Move @xyflow/react to devDependencies in workflow-persistence (type-only import). - Remove the minimatch and brace-expansion overrides: forcing minimatch 10 broke CommonJS consumers like @electron/asar, and every major line now resolves to a patched backport. - Remove redundant socket.io, baseline-browser-mapping, drizzle-orm, and joi (artillery-only) overrides, sharp from trustedDependencies (no lifecycle scripts), and the temporary electron release-age exclude. The electron@latest canary bypasses the age gate explicitly. - Declare buffer, process, chai, and tinyrainbow, which the sandbox bundle build imports but only resolved through hoisting.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
[Low impact] The PR appears safe to merge; no actionable issues were found. SummaryThis PR cleans up dependency declarations and the lockfile.
No actionable issues were found. Builds and tests were not run. Intent noted: waleedlatif1 explicitly chose on-demand Artillery installation and a release-age bypass for the latest-Electron canary. Reviews (1) · Last reviewed commit: "chore(deps): dependency hygiene cleanup" · Reviewed by Greptile |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
qs(6.16.0 → 6.16.1, GHSA-6pq8) andfast-uri(3.1.8 → 3.1.9, GHSA-w74x/xhq7/wjr9/333x) override pins; the pinned versions were themselves the vulnerable releasesartillerydevDependency (~300 lockfile entries, plus its csv-parse 4 / moment advisories); the threeload:workflow:*scripts runbunx artillery@2.0.34minimatch/brace-expansionoverrides: forcing minimatch 10 (nodefaultexport) onto CommonJS consumers like@electron/asar(minimatch_1.default(...)) is a latent TypeError, and every major line now resolves to a patched backport (3.1.5 / 5.1.9 / 9.0.9 / 10.2.6, brace-expansion 1.1.21 / 2.1.7 / 5.0.12)socket.io,drizzle-orm,baseline-browser-mappingresolve the same versions without them;joionly came in through artillery),sharpfromtrustedDependencies(no lifecycle scripts), and the temporaryelectronrelease-age exclude. Theelectron@latestcanary passes--minimum-release-age=0so it still tests the real latest@xyflow/reactis a devDependency ofworkflow-persistence(type-only import)buffer,process,chai,tinyrainbow, which the sandbox bundle build imports but which only resolved through hoistingType of Change
Testing
bun installlock diff: only the intended versions changed, no other version churn; 2968 → 2669 lockfile entriesbun audit: 47 → 40, nothing new; no minimatch/brace-expansion findingsbun pm untrustedunchanged apart from artillery-only packages;build:sandbox-bundlesoutput identical with and without the changecheck:audits(incl. knip) and the test suites run in CIChecklist
test-auditauthoring gate)