fix(files): cap how long a room delivery waits for its refetches by waleedlatif1 · Pull Request #9427 · simstudioai/sim

waleedlatif1 · 2026-10-29T00:20:25Z

Summary

The room coalescing from perf(db): cut hot-path database work and close copilot cleanup gaps #9419 awaits each delivery's refetches before the next delivery, but a fetch has no timeout of its own: one that hung held the room's deliveries forever, so the tab stopped picking up remote file changes
Each delivery now waits at most DELIVERY_SETTLE_CAP_MS (60s, above the slowest list read) via the existing withinDeadline helper, which clears its timer; past it, the next delivery's invalidateQueries (cancelRefetch: true) cancels and restarts the hung fetch, the recovery every broadcast gave before coalescing
Normal deliveries are unchanged: a refetch that settles within the cap is still waited for, never overlapped; a hung first load (no cached data) is joined rather than restarted, as before

Type of Change

Bug fix

Testing

New test: a refetch that never settles no longer blocks the next delivery; fails on the pre-fix hook ("expected 2 times, got 1"), passes after; the existing coalescing tests still pass (6/6)
bun run lint, bun run check:audits (61), bun run type-check

Checklist

Code follows project style guidelines
Self-reviewed my changes
Tests added/updated and passing (new tests pass the test-audit authoring gate)
No new warnings introduced
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

The coalescing in #9419 awaits each delivery's refetches before the next one starts, so a refetch still in flight is neither cancelled nor overlapped. A fetch has no timeout of its own, so one that hung held the room's deliveries forever and the tab stopped picking up remote changes. Each delivery now waits at most DELIVERY_SETTLE_CAP_MS; past it, the next delivery's invalidation cancels and restarts the hung fetch, as every broadcast did before coalescing. Autopsy: the coalescing tests covered a refetch that settles late, never one that does not settle.

vercel · 2026-10-29T00:20:28Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated
docs	Skipped		Oct 29, 2026 12:42am UTC

greptile-apps · 2026-10-29T00:22:57Z

Confidence Score: 5/5

[Medium impact] The PR appears safe to merge.

Summary

Caps how long each room delivery waits for its refetches.

Workspace room refreshes resume after a callback waits longer than 60 seconds.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Room change arrives] --> B[Run callbacks]
  B --> C[Wait for refetches or 60-second cap]
  C --> D[Wait one second]
  D --> E{More changes arrived?}
  E -->|Yes| B
  E -->|No| F[Finish delivery]

_{Reviews (3) · Last reviewed commit: "fix(files): cap a room delivery's wait a..." · Reviewed by Greptile}

cubic-dev-ai

All reported issues were addressed across 2 files

_{Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic}

waleedlatif1 · 2026-10-29T00:31:33Z

@greptile

waleedlatif1 · 2026-10-29T00:31:34Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-10-29T00:31:39Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

All reported issues were addressed across 2 files

_{Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic}

… list read

waleedlatif1 · 2026-10-29T00:43:03Z

@greptile

waleedlatif1 · 2026-10-29T00:43:04Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-10-29T00:43:08Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 2 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Turn on auto-fix | Re-trigger cubic}

…and make room refetches wait (#9433) Release-review fixes for #9419/#9427: room callbacks must return their invalidations (tables and workflows rooms now wait for their refetches); the deployed-state hint is set only by active reads; chat cleanup keeps any chat-scoped key a surviving chat in its scope still attaches (one query per scope) and collects a forked workspace upload once no file row names it; inline images are swept by their chat prefix through their own outbox event; malformed attachment keys are skipped. Legacy queued payloads are still accepted.

vercel Bot temporarily deployed to Preview October 29, 2026 00:20 Inactive

cubic-dev-ai Bot reviewed Oct 29, 2026

View reviewed changes

Comment thread apps/sim/app/workspace/[workspaceId]/hooks/use-workspace-invalidation-room.ts

docs(files): say which hung refetches a capped room delivery recovers

4aec312

vercel Bot temporarily deployed to Preview October 29, 2026 00:31 Inactive

waleedlatif1 mentioned this pull request Oct 29, 2026

v0.9.37: workspace files paging and search, token sealing by default, scim hardening, db indexes #9426

Merged

cubic-dev-ai Bot reviewed Oct 29, 2026

View reviewed changes

Comment thread apps/sim/app/workspace/[workspaceId]/hooks/use-workspace-invalidation-room.ts

fix(files): cap a room delivery's wait at a minute, above the slowest…

bf44de4

… list read

vercel Bot temporarily deployed to Preview October 29, 2026 00:42 Inactive

cubic-dev-ai Bot reviewed Oct 29, 2026

View reviewed changes

waleedlatif1 merged commit e05cf89 into staging Oct 29, 2026
63 of 64 checks passed

waleedlatif1 deleted the fix/invalidation-delivery-cap branch October 29, 2026 00:55

waleedlatif1 mentioned this pull request Oct 29, 2026

fix(cleanup): keep shared chat files, sweep inline images by prefix, and make room refetches wait #9433

Merged

6 tasks done

Conversation

waleedlatif1 commented Oct 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Type of Change

Testing

Checklist

Uh oh!

vercel Bot commented Oct 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

greptile-apps Bot commented Oct 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 5/5

Summary

Diagram

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

waleedlatif1 commented Oct 29, 2026

Uh oh!

waleedlatif1 commented Oct 29, 2026

Uh oh!

cubic-dev-ai Bot commented Oct 29, 2026

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

waleedlatif1 commented Oct 29, 2026

Uh oh!

waleedlatif1 commented Oct 29, 2026

Uh oh!

cubic-dev-ai Bot commented Oct 29, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This branch was previously deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

waleedlatif1 commented Oct 29, 2026 •

edited

Loading

vercel Bot commented Oct 29, 2026 •

edited

Loading

greptile-apps Bot commented Oct 29, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading