Skip to content

fix(docs): restore container expansion and verify canvas interactions - #9502

Merged
waleedlatif1 merged 3 commits into
stagingfrom
codex/docs-canvas-review-fixes
Oct 31, 2026
Merged

waleedlatif1 merged 3 commits into
stagingfrom
codex/docs-canvas-review-fixes

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Oct 31, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Restore opening inline Loop and Parallel previews from their container bodies.
  • Replace the retired inspector benchmark with required canvas pan, zoom, drag, and dismissal checks.
  • Add browser regression coverage for container-body activation.
  • Exercise denied Search chat navigation after the server response completes before client hydration, retaining the existing browser-error and authorization checks.

Type of Change

  • Bug fix

Testing

Test-first CI reproduced container-body failures in Chromium and WebKit at 390, 768, and 1440px. The replacement interaction benchmark completed 132 observations with real pan, zoom, and drag measurements. Focused Biome and diff checks passed; post-fix browser checks and the streamed-denial regression are running in CI.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Oct 31, 2026 6:34am UTC

Request Review

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 31, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@waleedlatif1
waleedlatif1 marked this pull request as ready for review October 31, 2026 06:31

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@greptile-apps

greptile-apps Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] The PR appears safe to merge; no actionable issues were found.

Summary

Adds the missing node-click callback so inline Loop and Parallel container bodies can open the workflow lightbox.

  • Clicking a Loop or Parallel body opens the workflow lightbox.
  • The workflow benchmark checks canvas pan, zoom, and block dragging.
  • The browser suite follows denied-chat pages back to Home.

Reviews (2) · Last reviewed commit: "test(search): verify navigation after st..." · Reviewed by Greptile

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 31, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit b3f9298 into staging Oct 31, 2026
31 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/docs-canvas-review-fixes branch October 31, 2026 06:36

This branch was previously deployed

1 inactive deployment
Preview — edd6c2b4 Deployed Oct 31, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant