Repository navigation
fix(files): accept files/ VFS paths in v2 file describe, rename and delete - #9504
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
[Medium impact] The PR appears safe to merge; no new actionable issues were found. SummaryAdds
Review checks were read-only; tests were not run.
|
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 9 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
…uffixes or ambiguity
Collaborator
Author
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
This was referenced Oct 31, 2026
Merged
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
files describe,files renameandfiles delete(v2GET /files/[fileId]/metadata,PATCH/DELETE /files/[fileId]) now take a file's exactfiles/<folder>/<name>VFS path as well as its id — the same formfiles read,globand listings already print, and the form the text route already acceptsInvalid file id(~300 calls a week), each costing a wasted model round plus a listing call to recover the idresolveActiveWorkspaceFileContext: afiles/path resolves to an id inside the asserted workspace first, then the canonical load, workspace check and use-case authorization run on that id unchanged. Id inputs take the exact same path as beforeType of Change
Testing
lib/workspace-files/__integration__/file-path-references.integration.tsagainst real Postgres: 6/6 green; with the resolver reverted 5/6 go red (the 6th is a guard that uploads stay unreachable)bun run lint, block registry check,check:api-validation:strict,check:openapi,check:cli-api,check:mcp-operations,check:cli-docs,check:v2-route-table,check:utils,check:comment-hygiene,check:test-patterns,check:explicit-any,check:file-names,check:source-conventionscheck:auditsand the test suites run in CIChecklist
test-auditauthoring gate)