Skip to content

fix(ci): drop the duplicate --accept-routes the Tailscale action already passes - #9543

Merged
waleedlatif1 merged 1 commit into
stagingfrom
fix/ci-tailnet-accept-routes
Nov 1, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
fix/ci-tailnet-accept-routes

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • tailscale/github-action already passes --accept-routes on Linux, so the args: --accept-routes added in chore(ci): reach the database over the tailnet when CI_DB_TAILNET is set #9541 made tailscale up fail with "flag provided multiple times" and the "Join the tailnet" step never connected
  • Remove the duplicate from migrate.yml and docs.yml; the comment now says the action supplies the flag
  • Still gated by CI_DB_TAILNET, which is unset again, so this changes nothing until the staging route test is re-run

Type of Change

  • Bug fix (CI)

Testing

  • Reproduced on a staging workflow_dispatch of migrate.yml with CI_DB_TAILNET=true: "Join the tailnet" failed on the duplicate flag before checkout, so nothing reached the database; the variable was removed right after
  • Confirmed in the action source (v4.2.0) that it appends --accept-routes itself
  • actionlint -shellcheck= -pyflakes= clean

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Nov 1, 2026 4:54am UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no actionable defects were established.

Summary

Removes the explicit --accept-routes argument from the Tailscale steps in both workflows.

  • The migration and docs workflows rely on the Tailscale action for route acceptance.

Reviews (1) · Last reviewed commit: "fix(ci): drop the duplicate --accept-rou..." · Reviewed by Greptile

This branch was successfully deployed

1 active deployment
Preview — 9d7c91aa Deployed Nov 1, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant