Repository navigation
fix(ci): drop the duplicate --accept-routes the Tailscale action already passes - #9543
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
[Medium impact] The PR appears safe to merge; no actionable defects were established. SummaryRemoves the explicit
Reviews (1) · Last reviewed commit: "fix(ci): drop the duplicate --accept-rou..." · Reviewed by Greptile |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tailscale/github-actionalready passes--accept-routeson Linux, so theargs: --accept-routesadded in chore(ci): reach the database over the tailnet when CI_DB_TAILNET is set #9541 madetailscale upfail with "flag provided multiple times" and the "Join the tailnet" step never connectedmigrate.ymlanddocs.yml; the comment now says the action supplies the flagCI_DB_TAILNET, which is unset again, so this changes nothing until the staging route test is re-runType of Change
Testing
workflow_dispatchofmigrate.ymlwithCI_DB_TAILNET=true: "Join the tailnet" failed on the duplicate flag before checkout, so nothing reached the database; the variable was removed right after--accept-routesitselfactionlint -shellcheck= -pyflakes=cleanChecklist
test-auditauthoring gate)