Repository navigation
fix(sandbox): initialize workbench history before honoring a stop during creation - #9549
Merged
Merged
Conversation
…ing creation A chat workbench created while the caller stopped kept running for the next call to reuse, but the abort check ran before its history was initialized. The reused machine then had no history, so it could never be certified and every later code result in that chat was withheld.
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
[Medium impact] The PR appears safe to merge. SummaryInitializes a newly created workbench's input history before honoring cancellation, so the next call can safely reuse it.
Reviews (2) · Last reviewed commit: "fix(sandbox): type the certification run..." · Reviewed by Greptile |
Collaborator
Author
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
run_code) keeps existing for the next call to reuse, butensureSessionSandboxchecked the abort before initializing the machine's input historyunknown, and every later code/shell result in that chat is withheld ("Tool execution settled, but its result could not be returned safely") until the machine is discarded — even when the code succeededType of Change
Testing
session-input-certification.integration.ts(real Redis history script, code + shell): the caller stops while the provider is creating the machine, then the next call reuses it and must return its result with clean historyWorkbench output withheld because its secret provenance is unavailable, green with the fix; existing certification cases unchangedsession-file-provenance.integration.tsand alllib/execution/remote-sandboxunit tests pass (574)Checklist
test-auditauthoring gate)