Repository navigation
fix(billing): fail closed on legacy Chat payer reads and cover the Chat plan gate - #9553
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
[Low impact] The PR appears safe to merge, with no outstanding actionable findings. SummaryLegacy-account subscription reads now use
Reviews (3) · Last reviewed commit: "test(billing): pass the route context in..." · Reviewed by Greptile |
Collaborator
Author
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
Collaborator
Author
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
onError: 'throw', matching the direct-account branch. A transient DB error used to read as "no subscription", so the Chat plan check could refuse a paying payer with a 402; it now fails closed with a retryable 500chat-access.integration.ts: the Chat plan verdict against real Postgres balances — a free org payer and a free personal payer are refused until they hold prepaid credits, and a paid payer is admitted with no balanceType of Change
Testing
run.test.tsandvalidate/route.test.tspass in full (198 tests)chat-access.integration.tspasses against Postgres viabun run test:integration(3 tests)balance > 0→>= 0fails both free-payer integration cases; deleting the paid-plan early return fails the paid-payer caseChecklist
test-auditauthoring gate)