Skip to content

fix(ci): persist dependency caches and restore default-branch seeds - #9554

Closed
waleedlatif1 wants to merge 2 commits into
stagingfrom
codex/streamline-ci-setup
Closed

waleedlatif1 wants to merge 2 commits into
stagingfrom
codex/streamline-ci-setup

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Nov 2, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Restore and save GitHub dependency caches explicitly around installation. Nested post-job cache saves currently lose their path input and leave no reusable dependency archive.
  • Keep the GitHub Turbo cache step directly in setup with a literal save path.
  • Let trusted PRs fall back to default-branch push caches, with an identical lockfile required for node_modules. Keep fork and save namespaces separate.
  • Elect one dependency-cache writer for the integration matrix and skip uploads on exact hits, avoiding redundant compression and reservation races.

Type of Change

  • Performance improvement
  • Bug fix

Testing

  • actionlint and git diff --check pass.
  • All 62 repository audits and all 29 workspace type-checks pass.
  • Full repository tests pass: 20 Turbo tasks, including 3,451 app files and 39,285 passing app assertions.
  • Hosted CI on the final revision passed, including real database, HTTP, browser and Electron suites.
  • Hosted logs confirm both dependency archives save and restore across revisions. An integration reader restored both without invoking a save action; the designated writer restored and saved both without a reservation collision or missing-path warning.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Existing tests passing; no test assertions changed
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Ignored Ignored Preview Nov 2, 2026 2:20am UTC

Request Review

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@greptile-apps

greptile-apps Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no blocking issues were found.

Summary

The PR moves GitHub dependency-cache saves directly after installation and lets trusted PRs restore push caches with a matching lockfile.

  • Trusted pull requests can reuse eligible default-branch dependency caches.
  • One integration job saves dependency caches when an archive is needed.
  • GitHub-hosted jobs restore and save the Turbo cache directly.

Reviews (2) · Last reviewed commit: "improvement(ci): elect one dependency ca..." · Reviewed by Greptile

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

Superseded by #9556, now squash-merged into staging. The replacement avoids dependency archives that restore more slowly than installation, retains provider-specific Turbo caching, and includes the acceptance critical-path improvements.

@waleedlatif1
waleedlatif1 deleted the codex/streamline-ci-setup branch November 2, 2026 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant