Repository navigation
improvement(chat): let Chat manage sim links, bulk-add permission group members, and preview member removal - #9600
Merged
Conversation
…up members, and preview member removal
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
[High impact] The PR appears safe to merge; no actionable issues were found. SummaryChat can now manage Sim links, bulk-add permission group members, and preview which credentials would stop working after a member leaves.
Acknowledged behavior: waleedlatif1 explicitly states in the PR description that non-member self-preview now returns 403 instead of 200. This change is intentional. Reviews (1) · Last reviewed commit: "improvement(chat): let Chat manage sim l..." · Reviewed by Greptile |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sim:settingsaudience) and are exposed as asettings organization/sim-linkssection. Addedorganization.sim_links.get(by id or name, hiding unlisted links exactly as browsing does). Flag check, creator/admin/restrictEdit rules, and audit stay in the existing use cases.resolve/suggeststay session-only so Chat can't inflate visit countsbulk_add_membersop onorganization/access-control, calling the existing use case with the v2 input limitsremoval-impactroute behind apreviewOrganizationMemberRemovaluse case (admins preview anyone, members only themselves) and added aremoval_impactread op onorganization/membersso Chat can preview before removing. Contract and{ credentials }body unchanged; a non-member asking about themselves now gets 403 instead of 200Type of Change
Testing
member-removal.test.ts: delegated non-admin refused when previewing someone else (red with the admin-or-self check removed), delegated member can preview leaving; 7/7bun run lint,check:api-validation:strict,check:boundaries,check:principal-kind-parity,check:application-graph,check:permission-group-enforcement,check:mcp-operations,check:openapi,check:cli-api,check:client-boundary, pre-pushtype-checkChecklist
test-auditauthoring gate)