Skip to content

improvement(chat): let Chat manage sim links, bulk-add permission group members, and preview member removal - #9600

Merged
waleedlatif1 merged 1 commit into
stagingfrom
improvement/chat-admin-settings-gaps
Nov 3, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
improvement/chat-admin-settings-gaps

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Nov 3, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Sim links: list/get/create/update/delete now accept a Copilot-delegated principal (sim:settings audience) and are exposed as a settings organization/sim-links section. Added organization.sim_links.get (by id or name, hiding unlisted links exactly as browsing does). Flag check, creator/admin/restrictEdit rules, and audit stay in the existing use cases. resolve/suggest stay session-only so Chat can't inflate visit counts
  • Permission groups: new bulk_add_members op on organization/access-control, calling the existing use case with the v2 input limits
  • Member removal impact: moved the raw removal-impact route behind a previewOrganizationMemberRemoval use case (admins preview anyone, members only themselves) and added a removal_impact read op on organization/members so Chat can preview before removing. Contract and { credentials } body unchanged; a non-member asking about themselves now gets 403 instead of 200
  • No approval gates added

Type of Change

  • Improvement

Testing

  • member-removal.test.ts: delegated non-admin refused when previewing someone else (red with the admin-or-self check removed), delegated member can preview leaving; 7/7
  • Existing settings, settings-management-boundary, settings-collections, organizations and permission-groups use-case tests: 55 passing
  • bun run lint, check:api-validation:strict, check:boundaries, check:principal-kind-parity, check:application-graph, check:permission-group-enforcement, check:mcp-operations, check:openapi, check:cli-api, check:client-boundary, pre-push type-check

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Nov 3, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Nov 3, 2026 2:43am UTC

Request Review

@greptile-apps

greptile-apps Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[High impact] The PR appears safe to merge; no actionable issues were found.

Summary

Chat can now manage Sim links, bulk-add permission group members, and preview which credentials would stop working after a member leaves.

  • Chat can manage an organization’s Sim links from Settings.
  • Chat can add many organization members to a permission group at once.
  • Chat can preview which credentials a member’s removal affects.

Acknowledged behavior: waleedlatif1 explicitly states in the PR description that non-member self-preview now returns 403 instead of 200. This change is intentional.

Reviews (1) · Last reviewed commit: "improvement(chat): let Chat manage sim l..." · Reviewed by Greptile

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 12 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 1ea6c7f into staging Nov 3, 2026
79 checks passed
@waleedlatif1
waleedlatif1 deleted the improvement/chat-admin-settings-gaps branch November 3, 2026 03:42

This branch was previously deployed

1 inactive deployment
Preview — 6868f428 Deployed Nov 3, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant