Repository navigation
fix(chat): hide the Sim links settings section where Sim links are off - #9615
Merged
Merged
Conversation
Chat's settings list advertised the Sim links section to every organization. Its operations already refused when the rollout flag was off, but Chat would still offer it. describeSection now drops it for those organizations, so list omits it and open/get/describe/execute refuse it up front.
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
[Low impact] This change appears safe to merge. SummaryChat now hides the organization Sim links section when its rollout flag is off.
No actionable issues found. Review was based on source inspection; no tests were run. Reviews (1) · Last reviewed commit: "fix(chat): hide the Sim links settings s..." · Reviewed by Greptile |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
settingstool listed the organization Sim links section in every organization, even where the Sim links rollout flag is offdescribeSectionnow returns nothing for that section whenisSimLinksEnabledis false, solistomits it andopen/get/describe/executerefuse it up frontType of Change
Testing
Checklist
test-auditauthoring gate)🤖 Generated with Claude Code