Repository navigation
fix(release): report short workbench timeouts, gate Sim links in Chat settings, scope the Chat plan modal - #9616
Merged
Merged
Conversation
… settings, scope the Chat plan modal - A workbench run with a short budget kept no time for its own timeout to answer, so the call deadline won and the output it printed was lost; hold back a small report reserve and bound the output listing by the time left - Chat listed the Sim links settings section to every organization; a settings adapter can now declare whether its section exists, and Sim links does so from its rollout flag - The Chat plan modal stays with the workspace whose send opened it - Organization conversations ask to upgrade the organization's plan
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
[Medium impact] The PR appears safe to merge; no actionable issues were found. SummaryThis PR fixes three release behaviors:
No actionable issues were found. The review checked code paths; it did not run tests or capture the UI.
|
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 9 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
settingstool no longer lists the Sim links section to organizations without Sim links enabled. A settings adapter can declareavailable, whichdescribeSectionchecks before listing, opening, reading or executing the sectionType of Change
Testing
session-sandbox.test.tscase: a 10s workbench run whose provider answers its own timeout one round trip late. Red on the pre-fix code, and red again with only the listing bound reverted; green with the fixsettings.test.tscase: Sim links is not listed, andopen/getare refused, without the flag; it is listed with the flag. Red with the gate removedsession-sandbox.test.ts,e2b-session.test.ts,execute-request.test.ts,settings.test.ts,settings-management-boundary.test.ts: all pass. biome is clean on the changed filescheck:auditsand the full suite are left to CIChecklist
test-auditauthoring gate)