Skip to content

fix(release): report short workbench timeouts, gate Sim links in Chat settings, scope the Chat plan modal - #9616

Merged
waleedlatif1 merged 1 commit into
stagingfrom
fix/release-0942-review
Nov 3, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
fix/release-0942-review

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Workbench runs with a short budget (20s or less) now report their timeout progress. The command used to get the whole remaining budget, so the call deadline fired before the run's own timeout could answer, and the output it had printed was dropped. A small report reserve (a quarter of the budget, at most 4s) is held back, and the output listing in the timeout report is bounded by the time left
  • Chat's settings tool no longer lists the Sim links section to organizations without Sim links enabled. A settings adapter can declare available, which describeSection checks before listing, opening, reading or executing the section
  • The Chat plan modal now stays with the workspace whose send opened it, so going back or forward to another workspace no longer shows a stale "Paid Plan Required"
  • In organization conversations, the plan-required copy asks to upgrade the organization's plan

Type of Change

  • Bug fix

Testing

  • New session-sandbox.test.ts case: a 10s workbench run whose provider answers its own timeout one round trip late. Red on the pre-fix code, and red again with only the listing bound reverted; green with the fix
  • New settings.test.ts case: Sim links is not listed, and open/get are refused, without the flag; it is listed with the flag. Red with the gate removed
  • session-sandbox.test.ts, e2b-session.test.ts, execute-request.test.ts, settings.test.ts, settings-management-boundary.test.ts: all pass. biome is clean on the changed files
  • Full type-check, check:audits and the full suite are left to CI

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

… settings, scope the Chat plan modal

- A workbench run with a short budget kept no time for its own timeout to answer, so the call deadline won and the output it printed was lost; hold back a small report reserve and bound the output listing by the time left
- Chat listed the Sim links settings section to every organization; a settings adapter can now declare whether its section exists, and Sim links does so from its rollout flag
- The Chat plan modal stays with the workspace whose send opened it
- Organization conversations ask to upgrade the organization's plan
@vercel

vercel Bot commented Nov 3, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Nov 3, 2026 6:22am UTC

Request Review

@greptile-apps

greptile-apps Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no actionable issues were found.

Summary

This PR fixes three release behaviors:

  • Short workbench runs keep enough time to report their timeout progress.
  • Chat settings show Sim links only for enabled organizations.
  • Chat plan prompts stay with the workspace that opened them.

No actionable issues were found. The review checked code paths; it did not run tests or capture the UI.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Workbench run] --> B[Keep time for a timeout report]
  B --> C[Run code or shell command]
  C --> D{Run timed out?}
  D -->|No| E[Return result]
  D -->|Yes| F[List output files within part of the time left]
  F --> G[Build timeout progress]
  G --> H[Release lease and check output safety]
  H --> I[Return timeout report]
Loading

Reviews (1) · Last reviewed commit: "fix(release): report short workbench tim..." · Reviewed by Greptile

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 9 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit a2495e3 into staging Nov 3, 2026
79 checks passed
waleedlatif1 added a commit that referenced this pull request Nov 3, 2026
…n upgrade copy (#9618)

#9614 gave organization routes their own message, so the organization wording #9616 added to `action` is never read

This branch was previously deployed

1 inactive deployment
Preview — 6efa7812 Deployed Nov 3, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant