Repository navigation
deps: Bump mollusk crates to 0.17 - #646
Merged
Merged
Conversation
Mollusk 0.17 pulls in agave 4.4, which moves to solana-account 5, solana-transaction 5, solana-keypair 4, solana-signer 4 and solana-stake-history 2. Bump the matching dev-dependencies. solana-account 5 only exposes `new_data`, `serialize_data`, etc. behind its `bincode` feature, which is no longer enabled indirectly. Enabling it breaks solana-runtime, which relies on the wincode versions of those methods, so move the tests to the `StateMutWincode` trait instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
joncinque
approved these changes
Nov 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
mollusk-svmandmollusk-svm-resultare on 0.16, and the latest release is 0.17.1.Summary of changes
mollusk-svmandmollusk-svm-resultfrom 0.16.0 to 0.17.1.solana-program-testand the other agave crates from 4.3 to 4.4.1, and agave 4.4 uses new major versions of several SDK crates. To keep the test types consistent, these dev-dependencies are bumped:solana-account4 → 5solana-transaction4 → 5solana-keypair3 → 4solana-signer3 → 4solana-stake-history1 → 2.1, matchinginterfacesolana-account5 only provides the bincode helpers (new_data,new_data_with_space,serialize_data,deserialize_data,StateMut) when itsbincodefeature is on. Before, that feature was enabled indirectly by other crates, and now it isn't. Turning it on explicitly breakssolana-runtime4.4.1, which expects the wincode versions of those methods. So the tests now usestate_traits::StateMutWincode, which most ofstake_instruction.rsalready used:merge.rstests:StateMut→StateMutWincodetests/interface.rs:Account::new_dataanddeserialize_data→StateMutWincodetests/stake_instruction.rs:serialize_data→set_state. Four call sites passed&statewherestatewas already a reference; they now passstate, because the wincode trait infersT = &StakeStateV2otherwise.Cargo.lockis updated withcargo update -p mollusk-svm -p mollusk-svm-result.Only tests and dev-dependencies change; the program's own dependencies are untouched.
Locally, all of these pass:
make build-sbf-programmake test-program(360 tests),make test-interfaceandmake test-clients-rust-D warnings --all-targetscargo fmt --checkandmake audit🤖 Generated with Claude Code