Repository navigation
deps: Bump spl-token-2022 to v12 - #166
Closed
clankmaxxing-clod wants to merge 2 commits into
Closed
clankmaxxing-clod wants to merge 2 commits into
clankmaxxing-clod wants to merge 2 commits into
Conversation
Bumps [spl-token-2022](https://github.com/solana-program/token-2022) from 11.1.0 to 12.0.0. - [Release notes](https://github.com/solana-program/token-2022/releases) - [Commits](https://github.com/solana-program/token-2022/compare/program@v11.1.0...program@v12.0.0) --- updated-dependencies: - dependency-name: spl-token-2022 dependency-version: 12.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
spl-token-2022 v12 moved to pinocchio, so its processor takes `&mut [AccountView]` and can no longer be registered as a native builtin with `processor!`. Load the program from a fixture instead, built from the program@v12.0.0 tag with cargo-build-sbf, matching how transfer-hook tests load Token-2022. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Closing in favor of switching to spl-token-2022-interface. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #154, whose CI fails because the tests don't compile against v12.
Problem
spl-token-2022 v12 moved to pinocchio (solana-program/token-2022#1469), so
Processor::processnow takes&mut [AccountView]. It can no longer be registered withprocessor!insolana-program-test:Summary of changes
spl-token-2022from 11.1.0 to 12.0.0 (from build(deps): bump spl-token-2022 from 11.1.0 to 12.0.0 #154)program/tests/fixtures/spl_token_2022.so, the same approach transfer-hook uses.prefer_bpf(true)is set before adding it, so the fixture is used whether or notSBF_OUT_DIRis set.program@v12.0.0tag of solana-program/token-2022 withcargo-build-sbf4.4.0 (sha256c3b1e851c21d1c68520e1ee841a5383931369037175f93671efed1c96027e638)Checked locally:
make format-check-program,make clippy-program,make build-sbf-program && make test-programall pass.🤖 Generated with Claude Code