Repository navigation
docs: live() implies GET, liveQuery implies live() - #1666
Merged
Merged
Conversation
live(fn) declares GET itself (solid rc.17) and router liveQuery declares a server function live() itself (router next.42): drop live(GET(...)) and liveQuery(live(...)) from the guides and the router reference. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Fmb4aQtDJWoA8CUktR9QoZ
|
|
✅ Deploy Preview for solid-docs-v2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Ryan · project thread
Follows solidjs/solid#4190 (in rc.17:
live(fn)declaresGETitself) and solidjs/solid-router#690 (in next.42:liveQuerydeclares a server functionlive()itself).live(async function* ...). I replaced the "placelive()outsideGET()/live()does not implyGET()" paragraph with one line sayinglive()declaresGET. The recap is updated too.withMetacomposition example drops the innerGET(), and the prose and recap now saylive()implies it.watchReplyislive(fn), and the live server component isliveQuery(fn, "thread")with nolive(GET(...))wrapper. TheliveQueryhoisting note and the recap are updated, and the now-unusedGET/liveimport is removed from the thread route example.data.mdx):liveQuerynow declares server functionslive(). The old text said it wraps them as GET.The generated
livereference page has no GET wording, so it's left alone.Checks:
prettier --checkandlint-tonepass on the changed files.check-examplesneeds a local solid-meta checkout, so I didn't run it.Generated by Claude Code