Skip to content

Add knip and remove dead code - #329

Merged
Bohreromir merged 5 commits into
mainfrom
feat/knip
Oct 21, 2026
Merged

Add knip and remove dead code#329
Bohreromir merged 5 commits into
mainfrom
feat/knip

Conversation

@Bohreromir

@Bohreromir Bohreromir commented Sep 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

This PR adds knip to prevent dead code from accumulating.

@Bohreromir
Bohreromir marked this pull request as ready for review September 21, 2026 14:37
@Bohreromir Bohreromir moved this to Development: Waiting for Review in Stackable Engineering Sep 22, 2026
@labrenbe
labrenbe self-requested a review September 22, 2026 12:20
@labrenbe labrenbe moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Sep 22, 2026
@Bohreromir
Bohreromir marked this pull request as draft September 24, 2026 17:30
@Bohreromir Bohreromir linked an issue Oct 1, 2026 that may be closed by this pull request
Remove unused dependencies #101
Closed
@Bohreromir Bohreromir mentioned this pull request Oct 1, 2026
Closed
@Bohreromir Bohreromir self-assigned this Oct 5, 2026
@Bohreromir
Merge remote-tracking branch 'origin/main' into feat/knip
4aa1801 
# Conflicts:
#	e2e/storage/helpers.ts
#	e2e/support/mock-oidc-server.ts
#	package-lock.json
#	package.json
#	src/lib/server/storage/preview/parquet.ts
#	src/lib/server/storage/types.ts
#	src/lib/server/trino/queries.ts
#	src/lib/storage/display-helpers.ts
@Bohreromir
refactor: remove dead code found by knip after merging main
a236871
@github-actions

github-actions Bot commented Oct 21, 2026 •
edited
Loading

Copy link
Copy Markdown

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 64.84% 8686 / 13394
🔵 Statements 63.95% 11687 / 18275
🔵 Functions 66.19% 2782 / 4203
🔵 Branches 55.04% 4989 / 9064
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/lib/components/layout/sidebar/nav-items.ts 0% 0% 0% 0% 14-42
src/lib/editor/completion/completion.ts 100% 100% 100% 100%
src/lib/server/db-tls.ts 100% 100% 100% 100%
src/lib/server/feature-flags.ts 96.66% 71.42% 100% 96.42% 163-165
src/lib/server/storage/archive.ts 79.95% 64.83% 96.87% 80.96% 119-122, 134-138, 150-161, 181, 191, 206-207, 216, 256, 266, 280-290, 378, 416, 468, 474, 477-484, 516, 540, 544-546, 557-559, 563-568, 573-580, 635, 664-666, 674-675, 684-685, 726, 757-759, 767-768, 777-778, 829, 902-906, 969, 978, 1049, 1078-1082, 1098-1108, 1119
src/lib/server/storage/download-manifests.ts 73.98% 57.83% 93.1% 75% 92, 225-226, 238, 248, 253-254, 277-311, 344-361
src/lib/server/storage/types.ts 0% 0% 0% 0%
src/lib/server/storage/transfer/http.ts 97.82% 92.85% 100% 97.43% 45
src/lib/server/trino/client.ts 65.43% 59.42% 53.33% 70.83% 80, 81, 93-94, 114-115, 132-142, 156, 166, 188-190, 195-201, 233-234, 240, 274-283
src/lib/storage/api.test-utils.ts 57.5% 94.44% 31.25% 54.05% 78-82, 113-121, 129-189
src/lib/storage/api.ts 63.49% 68.51% 59.37% 68.86% 230, 231, 232, 233, 234, 235, 301, 346-392, 408-409, 414, 415, 416, 426, 431-466
src/lib/storage/details-types.ts 0% 0% 0% 0%
src/lib/storage/search.svelte.ts 73.52% 60.24% 83.87% 77.14% 85, 104, 122, 132-143, 148, 161-173, 182-193, 199, 213, 218-219, 236, 277, 281, 305, 320-324
src/lib/storage/state.test-utils.ts 100% 100% 100% 100%
src/lib/storage/tabs.svelte.ts 85.51% 80.25% 93.33% 88.13% 185, 192, 248, 283, 296, 298, 311, 316, 331, 337, 371-372, 394, 414, 426-430, 438, 474-485, 523-524, 527, 532
src/lib/storage/transfer-types.ts 100% 100% 100% 100%
src/lib/storage/transfer.ts 92.5% 79.22% 95.23% 93.68% 39, 43-45, 49-53, 61, 98, 240
src/lib/storage/types.ts 100% 100% 100% 100%
src/lib/storage/upload.ts 2.94% 0% 11.11% 3.22% 33-102
src/lib/storage/utils.ts 100% 95.23% 100% 100%
src/routes/(app)/trino/query-runner.svelte.ts 0% 0% 0% 0% 33-313
src/routes/(app)/trino/validation.ts 33.33% 0% 0% 33.33% 8-27
Generated in workflow #1124 for commit 834e7b0 by the Vitest Coverage Report Action

@Bohreromir
Bohreromir marked this pull request as ready for review October 21, 2026 08:09
@Bohreromir Bohreromir moved this from Development: In Progress to Development: Waiting for Review in Stackable Engineering Oct 21, 2026
lfrancke
lfrancke reviewed Oct 21, 2026
View reviewed changes
Comment thread e2e/support/garage.ts
@lfrancke lfrancke moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Oct 21, 2026
@Bohreromir
Bohreromir merged commit eb8549f into main Oct 21, 2026
12 checks passed
@Bohreromir
Bohreromir deleted the feat/knip branch October 21, 2026 13:41
@Bohreromir Bohreromir moved this from Development: In Review to Development: Done in Stackable Engineering Oct 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lfrancke lfrancke lfrancke approved these changes
@labrenbe labrenbe Awaiting requested review from labrenbe

Assignees

@Bohreromir Bohreromir

Labels

None yet

Projects

Stackable Engineering
Status: Development: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove unused dependencies

3 participants

@Bohreromir @lfrancke @labrenbe