Skip to content

refactor: abstracting monolithic sdk client implementation into isolated services - #40

Open
LSchu wants to merge 62 commits into
mainfrom
refactor/service-implementations
Open

LSchu wants to merge 62 commits into
mainfrom
refactor/service-implementations

Conversation

@LSchu

@LSchu LSchu commented Nov 18, 2026 •

Copy link
Copy Markdown

This PR breaks up the monolithic sdk_client.go into small and testable packages for each service.
While the diff (currently) says +8,872 / -3,892 most of that is test code. The amount of actual net code added is about 1200 lines.

"drive-by-changes":

  • add legacy event permissions to capi deployment
  • create bastion host in a single AZ

For testing I created a bastion cluster and verified creation and deletion of all resources. I also tested the ssh connection to the bastion host and kube api access via the loadbalancer.

Open TODOs:

  • update and improve documentation
  • review and refine tests. Any change in *_test.go at this point is 100% AI.
  • rebase / include changes to network implementation.
  • cluster creation time is quite high and I am not sure if this is a regression. It can take up to 20 minutes for worker nodes to be provisioned.
  • there is still potential for simplification/refactoring of the new service implementations
  • there will be bugs and regressions I did not find so please test, test, test any scenario you can think of

LSchu added 30 commits October 27, 2026 15:12
LSchu added 24 commits November 13, 2026 15:42
@LSchu
LSchu marked this pull request as ready for review November 18, 2026 13:19
@LSchu
LSchu requested a review from a team November 18, 2026 13:19
…ce package

Signed-off-by: Jan Larwig <jan.larwig@digits.schwarz>
Signed-off-by: Jan Larwig <jan.larwig@digits.schwarz>
@tuunit tuunit changed the title Refactor service implementations refactor: abstracting monolithic sdk client implementation into isolated services Nov 18, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants