Repository navigation
Conversation
…or-security-groups
…se s.Region() in ClusterScope
…rity groups in CleanupByTags
…balancer services
…tionStatus to ClusterScope
…curitygroup services
…usterScope and MachineScope
LSchu
marked this pull request as ready for review
November 18, 2026 13:19
…ce package Signed-off-by: Jan Larwig <jan.larwig@digits.schwarz>
Signed-off-by: Jan Larwig <jan.larwig@digits.schwarz>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR breaks up the monolithic sdk_client.go into small and testable packages for each service.
While the diff (currently) says +8,872 / -3,892 most of that is test code. The amount of actual net code added is about 1200 lines.
"drive-by-changes":
For testing I created a bastion cluster and verified creation and deletion of all resources. I also tested the ssh connection to the bastion host and kube api access via the loadbalancer.
Open TODOs: