Repository navigation
fix: preserve useSessionStorage updates for shared keys - #2736
Open
wanxiankai wants to merge 1 commit into
Open
wanxiankai wants to merge 1 commit into
wanxiankai wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2604.
When two
useSessionStorageinstances share a key in the same render tree, updating the first instance also rerenders the second. The persistence effect currently runs after every render, so the second instance writes its unchanged state over the update. For example, setting"updated"leaves"initial"in session storage.Run the persistence effect when
key,raw, orstatechanges. This preserves writes when switching keys or serialization modes while allowing the changed instance's value to remain in storage. Instances continue to maintain their own React state.Add regression tests for shared keys in both JSON and raw modes, unrelated rerenders, key and mode changes, restricted storage access, empty serialized values, and the server fallback. Document the behavior of instances sharing a key.
Type of change
Validation
jest.config.node.ts.tsc --noEmit, CommonJS build, and ESM build pass.git diff --checkpasses.Checklist
useSessionStorage