Repository navigation
ci(ci): skip commits already on develop when linting release PRs - #199
Merged
Merged
Conversation
A release PR into main carries every develop commit, and Commit Lint re-checked all of them. Dependabot's "Bump ..." subjects fail subject-case and are only exempt on PRs Dependabot opened, so the v2.6.0 release PR failed the required check on eight commits that had already passed it on their way into develop. On PRs into main, also exclude commits reachable from develop, which requires the same check. PRs into develop lint exactly as before. The fetch now names its refspecs with "+" so it updates refs that actions/checkout already created instead of relying on FETCH_HEAD. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The v2.6.0 release PR (#198) fails the required Validate Commit Messages check on 8 Dependabot commits (
build(deps…): Bump …,subject-case). Those commits are exempt only on PRs Dependabot opened, so they passed on their way intodevelop. A release PR re-introduces them under a maintainer's account, and they get linted again.On PRs into
main, commits already ondevelopare now excluded, as commits already onmainalready were:developrequires the same check, so a commit reachable from it has already been linted or legitimately exempted. The Dependabot-PR path uses the samelandedlist.Evidence
I ran the workflow's own
Validate commitsscript locally against #198's real base and head:base.ref=develop, which matches CI): 32 commits linted, 8 Dependabot failures, exit 1.After (
base.ref=main): only8155a04 chore(changelog): update for v2.6.0is linted. It passes, exit 0.Merge Danger
Door: two-way. One workflow file and no data; revert to restore.
Blast Radius: narrow. Only PRs into
main, and there only commits already ondevelop, which have already passed the same required check.Related Issues
Unblocks #198.
Type of Change
Checklist
developbranch (only release PRs targetmain)feat:,fix:,refactor:, etc.) — they become the changelogCHANGELOG.mdby hand (it is generated from commit messages)README.md,docs/,examples/) if user-facing behavior changeduv run pytest tests/)uv run ruff check src/ tests/anduv run ruff format --check src/ tests/)uv run ty check src/swgoh_comlink/)🤖 Generated with Claude Code