Repository navigation
fix(deps): require certifi 2026.10.19 to drop compromised emSign CAs - #201
Merged
Merged
Conversation
certifi releases before 2026.10.18 trust the emSign ECC Root CA - G3, whose eight intermediates had their private keys compromised and were revoked (GHSA-6q48-6c7w-9gw2, critical). httpx verifies every connection against certifi's bundle, so an on-path attacker holding one of those keys could intercept the client's TLS traffic. certifi was only a transitive dependency through httpx, so upgrading swgoh-comlink never moved it: pip's only-if-needed strategy leaves an installed version alone while it satisfies the requirements. Declare it directly with a floor of 2026.10.19, the release that restores the unaffected emSign roots, so an upgrade now brings the fixed bundle. The lockfile moves to the same version. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
github-actions
Bot
added
the
dependencies
MarTrepodi
enabled auto-merge
October 22, 2026 16:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the critical Dependabot alert for GHSA-6q48-6c7w-9gw2.
certifibefore 2026.10.18 trusts the emSign ECC Root CA - G3, whose eight intermediates had compromised private keys. httpx verifies every connection against certifi's bundle, so an on-path attacker holding one of those keys could intercept the client's TLS traffic.certifiwas only an indirect dependency (through httpx), so upgrading swgoh-comlink never upgraded it. pip's defaultonly-if-neededstrategy leaves an installed dependency alone while it still satisfies the requirements. This PR declares it directly:dependencies = [ + "certifi>=2026.10.19", # with a comment: not imported; httpx's CA bundle "httpx>=0.28", "typing-extensions>=4.15.0", ]uv.lock: certifi 2026.5.20 → 2026.10.19. 2026.10.19 is the release that restores the emSign roots that weren't affected, so it's the floor rather than 2026.10.18.revision = 3 → 5change inuv.lockis the same back-and-forth as earlier hand-made lockfile edits (Dependabot writes 3). CI's unpinnedsetup-uvreads both.Evidence
uv.lockpinscertifi 2026.5.20, inside the vulnerable range>= 2019.03.09, < 2026.10.19, and alert General cleanup and example addition #31 is open.After:
uv lock --upgrade-package certifi→Updated certifi v2026.5.20 -> v2026.10.19. Locallycertifi.__version__ == "2026.10.19", andhttpx.create_ssl_context()builds against it. 1556 unit tests pass, and ruff and ty are clean.Merge Danger
Door: two-way. Dependency metadata only, with no code changes.
Blast Radius: small. Any user with an older
certifigets it upgraded when they upgrade this package. An environment that pinscertifi<2026.10.19(for example a frozen container) will fail to resolve. That's intended: it surfaces the vulnerable pin instead of silently keeping it.Related Issues
Resolves Dependabot alert #31 once released to
main.Type of Change
Checklist
developbranch (only release PRs targetmain)feat:,fix:,refactor:, etc.) — they become the changelogCHANGELOG.mdby hand (it is generated from commit messages)README.md,docs/,examples/) if user-facing behavior changeduv run pytest tests/)uv run ruff check src/ tests/anduv run ruff format --check src/ tests/)uv run ty check src/swgoh_comlink/)🤖 Generated with Claude Code