Repository navigation
feat(core): add Connection javadoc - #135
Merged
Merged
Conversation
nickkkccc
force-pushed
the
connection-javadoc
branch
3 times, most recently
from
October 23, 2026 06:54
8e94e3b to
2a6d124
Compare
bitgorbovsky
previously approved these changes
Oct 23, 2026
dkasimovskiy
requested changes
Oct 23, 2026
nickkkccc
force-pushed
the
connection-javadoc
branch
2 times, most recently
from
October 26, 2026 08:29
2113293 to
9dd9e49
Compare
bitgorbovsky
requested changes
Oct 26, 2026
| * the connection fails for any reason. Never null. | ||
| * @throws IllegalStateException if a connection attempt is made in a state where connecting is | ||
| * prohibited. The states in which connecting is prohibited are defined by the implementation. | ||
| * @throws IllegalArgumentException if {@code timeoutMs <= 0}. |
Contributor
There was a problem hiding this comment.
Тут надо дополнить, что не только в случае timeoutMs <= 0, но и в случае, если неправильное состояние
Contributor
Author
There was a problem hiding this comment.
Есть же, только другой тип исключения, чуть выше - IllegalStateException
dkasimovskiy
requested changes
Oct 26, 2026
nickkkccc
force-pushed
the
connection-javadoc
branch
from
October 26, 2026 14:53
cc1b2b9 to
e8ed1f5
Compare
dkasimovskiy
requested changes
Oct 26, 2026
- Fixed the notification sent to clients regarding connection
closure. It is now guaranteed that clients are notified of the
closure only after the connection has transitioned to the CLOSED
state.
- Fixed greeting object remaining non-null after connection closure.
nickkkccc
force-pushed
the
connection-javadoc
branch
from
October 26, 2026 16:56
e8ed1f5 to
8df8643
Compare
- Added documentation of Connection interface. - Added documentation of ConnectionCloseEvent enum.
nickkkccc
force-pushed
the
connection-javadoc
branch
from
October 26, 2026 16:56
8df8643 to
2abc7ca
Compare
bitgorbovsky
approved these changes
Oct 26, 2026
dkasimovskiy
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I haven't forgotten about:
Related issues: