Repository navigation
Fix XmlFileLoader fatal error on Symfony 6.4 - #254
Closed
Bullitt300 wants to merge 1 commit into
Closed
Bullitt300 wants to merge 1 commit into
Bullitt300 wants to merge 1 commit into
Conversation
Since 18.2.0 the bundled copy of the Symfony 7 XmlFileLoader is used on every Symfony version. It declares a typed property and calls loadExtensionConfig()/loadExtensionConfigs(), which only exist from Symfony 7.1 on, so every Magento 2.4.7 project (Symfony 6.4) fatals. The copy is renamed to Symfony7XmlFileLoader. XmlFileLoader now aliases it only if FileLoader::loadExtensionConfigs() exists, otherwise it aliases the XmlFileLoader shipped by Symfony, which disables the alias auto registration as well. Tested loading symfony/Resources/config/services.xml with symfony/dependency-injection 6.4.49, 7.0.10, 7.4.23 and 8.0.15. Co-Authored-By: C.L.A.U.D.I.A. (Claude Opus 5.5) <noreply@anthropic.com>
Contributor
|
The changes have been merged into PR 255. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since 18.2.0 the bundled copy of the Symfony 7 XmlFileLoader is used on every Symfony version. It declares a typed property and calls loadExtensionConfig()/loadExtensionConfigs(), which only exist from Symfony 7.1 on, so every Magento 2.4.7 project (Symfony 6.4) fatals.
The copy is renamed to Symfony7XmlFileLoader. XmlFileLoader now aliases it only if FileLoader::loadExtensionConfigs() exists, otherwise it aliases the XmlFileLoader shipped by Symfony, which disables the alias auto registration as well.
Tested loading symfony/Resources/config/services.xml with symfony/dependency-injection 6.4.49, 7.0.10, 7.4.23 and 8.0.15.