Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 6a8f1cc The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@aelmanaa is attempting to deploy a commit to the thirdweb Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Correct the status request and verify its API key packages/thirdweb/src/contract/verification/index.ts, packages/thirdweb/src/contract/verification/index.test.ts, .changeset/verify-status-apikey-quote.md |
The status request no longer adds a trailing double quote to the API key. The test checks the API key query parameter and returned response. The changeset records a patch release. |
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Bug fix · Severity of issue fixed: Low
Suggested labels: packages, SDK
Suggested reviewers: 0xfirekeeper
Merge Risk: 
6a8f1
-
The status request no longer appends a quote to the API key. No merge-blocking impact is apparent.
Pre-merge checks: 
-
Check name Status Explanation Title check The title clearly identifies the affected function and the trailing quote bug addressed by the pull request. Description check The description explains the bug, implementation change, test coverage, changeset, and linked issue. It does not use explicit template headings such as "Notes for the reviewer" or "How to test," but i… Linked Issues check [ #9049] The sole coding requirement is to remove the trailing double quote from the checkverifystatus request URL in checkVerificationStatus. The diff from merge base 940b374 to head 6a8f1cc changes i…Out of Scope Changes check All three changed files connect to #9049. (1) packages/thirdweb/src/contract/verification/index.ts: the one-line change removes the stray quote, which is the requested fix. (2) packages/thirdweb/src/c…Docstring Coverage No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… Full details: Description check
-
Explanation
The description explains the bug, implementation change, test coverage, changeset, and linked issue. It does not use explicit template headings such as "Notes for the reviewer" or "How to test," but it includes the required information and is mostly complete.
Full details: Linked Issues check
-
Explanation
[
#9049] The sole coding requirement is to remove the trailing double quote from the checkverifystatus request URL in checkVerificationStatus. The diff from merge base 940b374 to head 6a8f1cc changes index.ts line 212 by removing the trailing " after ${options.explorerApiKey}. The endpoint now ends with apikey=${options.explorerApiKey}. The issue's requested test is also present. index.test.ts uses MSW to intercept the checkverifystatus request and asserts that searchParams.get("apikey") equals TEST_API_KEY. Before the fix, this assertion would receive TEST_API_KEY" and fail, as the issue describes. The test runs with the 3000 ms polling interval inside a 10 s test timeout, so the first poll and assertion complete in time. No non-coding requirements exist in the issue.
Full details: Out of Scope Changes check
-
Explanation
All three changed files connect to
#9049. (1) packages/thirdweb/src/contract/verification/index.ts: the one-line change removes the stray quote, which is the requested fix. (2) packages/thirdweb/src/contract/verification/index.test.ts: a new Vitest/MSW regression test for the apikey query parameter. It supports the fix and is an expected test artifact. The test also checks the returned response fields, which covers the same function and does not add unrelated behavior. (3) .changeset/verify-status-apikey-quote.md: a patch changeset for thirdweb, which is release metadata for the same fix. No unrelated behavior, refactoring, or other API changes were found in the reviewed diff.
Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 2 files. (1 skipped: 1 unsupported.)
-
Finishing Touches
-
Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Removes a stray double quote that
checkVerificationStatusappended to the API key in its request URL."from thecheckverifystatusURL inpackages/thirdweb/src/contract/verification/index.ts.index.test.ts, which intercepts the request with MSW and asserts that theapikeyquery parameter equals the key passed in. It fails before the fix (TEST_API_KEY") and passes after.thirdweb.Fixes #9049
Summary by CodeRabbit