Repository navigation
Assert the leader domain in Sailfish - #242
Merged
Merged
Conversation
Signed-off-by: Qian-Cheng-nju <Qian-Cheng-nju@users.noreply.github.com>
Qian-Cheng-nju
force-pushed
the
sailfish-leader-domain
branch
from
October 20, 2026 17:24
3e67749 to
f009459
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LeadersAreNodesis declared inBlockDag, butINSTANCE BlockDagdoes not assert it inSailfish. The two TLC wrappers already check it explicitly; the standalone specification does not.A one-node instance shows the gap:
With
aandbdistinct, this satisfies Sailfish's other assumptions. Nodeareaches round 3 with an empty log, violatingLivenessbecause the designated round-1 leaderbnever had a vertex.Assert the existing
LeadersAreNodesdefinition after the instance. TLC then rejects this configuration before initialization. Changing the leader toastill reaches round 3 and commits<<a,1>>;TLCSailfish1also passes with unchanged state counts.