Skip to content

Carry third-party notices and fix the package copyright (#179) - #184

Merged
tomlm merged 3 commits into
mainfrom
licence-notices
Oct 31, 2026
Merged

tomlm merged 3 commits into
mainfrom
licence-notices

Conversation

@tomlm

@tomlm tomlm commented Oct 31, 2026

Copy link
Copy Markdown
Owner

Closes #179.

  • THIRD-PARTY-NOTICES.txt (new): the verbatim upstream notices for xterm.js (MIT), python wcwidth (MIT, plus Markus Kuhn's note), and libX11 Xcms (Tektronix permission notice), each with the files that derive from it.
  • XTerm.NET.csproj: Copyright changed from "All Rights Reserved" to "Copyright (c) 2025 Tom Laird-McConnell. Licensed under the MIT License."; LICENSE and THIRD-PARTY-NOTICES.txt are now packed into the nupkg.
  • XcmsColor.cs: the header named the wrong licence (MIT/X11); it now names the Tektronix notice.
  • README: the License section points to the notices file.

LICENSE itself is unchanged, so GitHub's licence detection still works.

Verified with dotnet pack: the nupkg contains LICENSE, THIRD-PARTY-NOTICES.txt and README.md, and the nuspec carries the MIT expression and the new copyright.

🤖 Generated with Claude Code

THIRD-PARTY-NOTICES.txt reproduces the upstream notices for xterm.js,
python wcwidth (the generated width tables) and libX11 Xcms (the colour
conversions). It ships in the nupkg alongside LICENSE. The csproj
Copyright no longer says "All Rights Reserved", which contradicted the
MIT licence expression, and the XcmsColor header now names the Tektronix
notice instead of calling it MIT/X11.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

Perf comparison — this change, against its base

3 run(s) of each side, alternating on one machine. Allocation is a count and is gated exactly. Time is a measurement, so its gate is derived from the spread this job just observed in itself rather than fixed in advance.

corpus bytes/char gen0/Mchar ns/char Δ time noise gate
scroll-ascii 0.00 → 0.00 0.00 → 0.00 2.74 → 2.72 -0.5% ±1% 4%
sgr-churn 0.00 → 0.00 0.00 → 0.00 7.30 → 7.31 +0.2% ±1% 4%
truecolor 0.00 → 0.00 0.00 → 0.00 7.75 → 7.65 -1.2% ±2% 5%
alt-redraw 0.00 → 0.00 0.00 → 0.00 11.49 → 11.50 +0.1% ±3% 10%
unicode 7.66 → 7.66 0.45 → 0.45 28.56 → 29.23 +2.4% ±7% 22%
flood 0.00 → 0.00 0.00 → 0.00 82.53 → 82.70 +0.2% ±1% 4%

Each corpus is gated at max(4%, 3 × its own noise). A wide noise column means this runner was busy and the timing half of the table should be read as advisory; the allocation half is exact either way.

assemblies measured
  • base: XTerm.NET 3.0.0.0 mvid:9fe73235-2e3d-4322-8516-6408463adf44
  • head: XTerm.NET 3.0.1.0 mvid:b4cda9c2-6c23-4b58-a42a-660b20914a63

Perf comparison — cumulative, everything since 3.0.0

3 run(s) of each side, alternating on one machine. Allocation is a count and is gated exactly. Time is a measurement, so its gate is derived from the spread this job just observed in itself rather than fixed in advance.

corpus bytes/char gen0/Mchar ns/char Δ time noise gate
scroll-ascii 0.00 → 0.00 0.00 → 0.00 2.73 → 2.72 -0.3% ±2% 5%
sgr-churn 0.00 → 0.00 0.00 → 0.00 7.31 → 7.31 -0.0% ±7% 22%
truecolor 0.00 → 0.00 0.00 → 0.00 7.71 → 7.65 -0.7% ±2% 6%
alt-redraw 0.00 → 0.00 0.00 → 0.00 12.03 → 11.50 -4.4% ±5% 15%
unicode 7.66 → 7.66 0.45 → 0.45 28.21 → 29.23 +3.6% ±7% 22%
flood 0.00 → 0.00 0.00 → 0.00 82.43 → 82.70 +0.3% ±1% 5%

Each corpus is gated at max(5%, 3 × its own noise). A wide noise column means this runner was busy and the timing half of the table should be read as advisory; the allocation half is exact either way.

assemblies measured
  • base: XTerm.NET 3.0.0.0 mvid:da88386b-bd83-461b-a7d7-b174fc659203
  • head: XTerm.NET 3.0.1.0 mvid:b4cda9c2-6c23-4b58-a42a-660b20914a63

@tomlm
tomlm merged commit 00f369d into main Oct 31, 2026
4 checks passed
@tomlm
tomlm deleted the licence-notices branch October 31, 2026 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Licence clarification: xterm.js notice missing from LICENSE, csproj says All Rights Reserved

1 participant