Repository navigation
Compute overloaded return type once per type - #2992
Draft
toinehartman wants to merge 26 commits into
Draft
toinehartman wants to merge 26 commits into
toinehartman wants to merge 26 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2992 +/- ##
=======================================
- Coverage 46% 46% -1%
- Complexity 6897 6899 +2
=======================================
Files 851 851
Lines 69233 69233
Branches 10084 10084
=======================================
- Hits 32064 32054 -10
- Misses 34741 34749 +8
- Partials 2428 2430 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
toinehartman
force-pushed
the
feature/tc-performance-overloads
branch
from
November 12, 2026 16:03
01b7be4 to
0ae860a
Compare
toinehartman
force-pushed
the
feature/tc-performance-overloads
branch
from
November 12, 2026 16:27
0ae860a to
6ecca6c
Compare
toinehartman
force-pushed
the
feature/tc-performance-overloads
branch
from
November 16, 2026 12:38
e219026 to
a665acf
Compare
toinehartman
force-pushed
the
feature/tc-performance-overloads
branch
3 times, most recently
from
November 17, 2026 09:30
c87e330 to
b2cb353
Compare
toinehartman
force-pushed
the
feature/tc-performance-overloads
branch
from
November 17, 2026 09:34
0e941bd to
70f831b
Compare
toinehartman
force-pushed
the
feature/tc-performance-overloads
branch
from
November 17, 2026 10:06
014cad6 to
2b66523
Compare
…utils' into feature/tc-performance-overloads
This reverts commit 7644a2a.
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Instead of doing the (expensive) return type computation once per overload, do it once per type, and use the results for all overloads with equal types.
This reduces the time needed to type-check highly overloaded and highly recursive modules significantly:
lang::rascal::format::Rascal: ~160s => ~60s