Skip to content

Add Module resolution handling for alias during import - #3003

Merged
PaulKlint merged 4 commits into
mainfrom
import-cycle-on-unloaded-module
Nov 17, 2026
Merged

PaulKlint merged 4 commits into
mainfrom
import-cycle-on-unloaded-module

Conversation

@jbdoderlein

Copy link
Copy Markdown
Contributor

This PR resolve #2940 , and a similar bug in a salix example (https://github.com/usethesource/salix-core/blob/main/src/main/rascal/salix/demo/basic/All.rsc)

It allow to use qualified name for module inside alias declaration in a module definition.

@codecov

codecov Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46%. Comparing base (23dde9c) to head (98e29af).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##              main   #3003   +/-   ##
=======================================
- Coverage       46%     46%   -1%     
+ Complexity    6899    6897    -2     
=======================================
  Files          851     851           
  Lines        69233   69233           
  Branches     10084   10084           
=======================================
- Hits         32064   32062    -2     
+ Misses       34737   34736    -1     
- Partials      2432    2435    +3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@PaulKlint PaulKlint left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. Integration tests succeed

@sonarqubecloud

Copy link
Copy Markdown

@PaulKlint
PaulKlint merged commit 4194fde into main Nov 17, 2026
3 checks passed
@PaulKlint
PaulKlint deleted the import-cycle-on-unloaded-module branch November 17, 2026 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Interpreter rejects qualified names in alias declarations

2 participants