Repository navigation
fix: A run that wraps in a list item is placed where it is - #1230
Merged
Merged
Conversation
mapRun searched for a run as written, but a run that wraps inside a list item or blockquote has the item's indentation or `>` after each line break in the source. The search missed it, or found a copy further down and moved the source cursor past every run after it, so their alerts were placed by searching the whole file. Place such a run with wrappedRuns, as locateWrapped already does for blocks. Fixes vale-cli#1227 Assisted-by: Claude Code
|
Before this is reviewed, please read the AI-Assisted Contributions section of the contributing guide and make sure this change meets it: you can explain every line, the description is your own and brief, it fixes a bug you hit or a feature agreed in an issue, it does not touch undocumented options, and any substantial tool use is noted. |
|
The license agreement is signed. |
Contributor
Author
|
I have read the CLA and I agree to it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mapRun searched for a run as written, but a run that wraps inside a list item or blockquote has the item's indentation or
>after each line break in the source. The search missed it, or found a copy further down and moved the source cursor past every run after it, so their alerts were placed by searching the whole file. Place such a run with wrappedRuns, as locateWrapped already does for blocks.Fixes #1227
Assisted-by: Claude Code