Repository navigation
fix: bind flags during PreRunE rather than init - #66
Merged
Merged
Conversation
We use one global viper instance for configuration (shared between all commands), however Flag objects exist per-command. When we were binding flags during command creation, they were overwriting each other, so that flags for only one of the verify commands ended up being bound to config, and the flags for other commands were being ignored (only verify commands use bindings, other commands do not and are unaffected by this). Binding during PreRunE ensures that the binding happens before RunE (where the config is read) but only for the command that is actually being run. Signed-off-by: Sergei Trofimov <sergei.trofimov@arm.com>
Contributor
Author
|
Cc @anta5010 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We use one global viper instance for configuration (shared between all commands), however Flag objects exist per-command. When we were binding flags to the viper object, during command creation, they were overwriting each other, so that flags for only one of the verify commands ended up being bound to config, and the flags for other commands were being ignored (only verify commands use bindings, other commands do not and are unaffected by this).
Binding during PreRunE ensures that the binding happens before RunE (where the config is read) but only for the command that is actually being run.