Skip to content

✨ Add agent disclosure and screenshot region comments - #398

Open
Robdel12 wants to merge 1 commit into
mainfrom
rd/agent-review-attribution
Open

Robdel12 wants to merge 1 commit into
mainfrom
rd/agent-review-attribution

Conversation

@Robdel12

@Robdel12 Robdel12 commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Why

Comments and review decisions should disclose agent assistance while keeping the logged-in user as the author. Screenshot feedback also needs a precise destination: an agent looking at an image should be able to comment on a rectangle in that image’s pixels.

Approach

Detect documented Codex, Claude Code, Pi, Gemini CLI and OpenCode markers at the shared HTTP write boundary. Only static agent details are sent; marker values, session IDs and prompts stay local. Explicit --via-agent or --no-agent-attribution wins over VIZZLY_VIA_AGENT, then automatic detection. Conflicting markers stop the write with a clear error.

comment accepts --screenshot, --region x,y,width,height and --reply-to. Raw API comments and decisions use the same disclosure path. Review commands now use the shared credential selector and granted-scope checks, so explicit tokens take precedence and the selected credential is shown consistently. Help and bundled review guidance explain the new behavior.

Evidence

The full CLI suite passed 1,892 tests with six existing skips. Real subprocess/HTTP tests cover every supported harness, overrides, opt-out, conflicts, region validation, token precedence and read-only scopes. The built CLI also completed comment and decision workflows against a real authenticated server and database. Architecture checks, public type checks, lint and distributable builds pass.

Release after the server supports optional via metadata and screenshot comment regions.

Disclose known agent assistance on review writes without transmitting harness identifiers. Support precise screenshot feedback and share credential selection, scope checks, and attribution with raw API commands.
@vizzly-testing

vizzly-testing Bot commented Nov 4, 2026

Copy link
Copy Markdown

Vizzly - Visual Test Results

CLI Reporter - Waiting for build

No builds received yet for this pull request.

CLI TUI - 3 changes need review
Result Count Review
Meaningful diffs 3 Required - inspect changed screenshots
Meaningful diffs needing review (3)

vizzly-help · 1202×1430 · 3.0% diff

vizzly-help

vizzly-tdd-help · 1202×578 · 0.2% diff

vizzly-tdd-help

vizzly-invalid-command · 1202×578 · 0.2% diff

vizzly-invalid-command

Review changes


rd/agent-review-attribution · 192d8f9a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant