Repository navigation
Conversation
…Metadata
`contentChildren(Pane)` in a class declared before `Pane` emitted
`setClassMetadata(..., { panes: [{ type: i0.ContentChildren, args: [Pane, ...] }] })`,
which reads `Pane` as soon as the class is defined: a TDZ ReferenceError in
development builds. Like ngtsc's `memberMetadataFromSignalQuery`, a predicate
other than a string or a call is now `i0.forwardRef(() => Pane)`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A signal query whose predicate is a class declared later in the file:
emitted
setClassMetadata(DParent, ..., { panes: [{ type: i0.ContentChildren, args: [DPane, { isSignal: true }] }] }).setClassMetadataruns as soon as the class is defined, so in development buildsDPanewas read before its initialization:ReferenceError: Cannot access 'DPane' before initialization, which stops the app. (The query initializer itself is fine: it runs later.)ngtsc's
memberMetadataFromSignalQuerywraps the predicate inforwardRefunless it is a string or a call expression, for this reason; this does the same:It applies whatever the declaration order, as in ngtsc. A string predicate (
viewChildren('ref')) and decorator queries are left as written. One deliberate difference: a spread first argument (viewChild(...args)) isn't wrapped, sinceforwardRef(() => ...args)isn't valid JavaScript.tests/signal_query_metadata_forward_ref_test.rschecks both declaration orders, an options object ({ ...{ read: ElementRef }, isSignal: true }), a string predicate and decorator queries against @angular/compiler-cli 21.0.1's output.