Repository navigation
docs(catalog): describe Readwise highlight titles and field kinds - #690
Merged
Merged
Conversation
aicayzer
marked this pull request as ready for review
October 29, 2026 15:02
Contributor
Author
|
Review depth: reviewed with withmarfa/marfa-connectors#308 over two rounds. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Readwise and Readwise Reader catalog pages now describe the highlight
titleandbodyfields, the date, time and address field kinds,original_values, and the schema step an existing install needs. This matches withmarfa/marfa-connectors#308, which should merge first, because these pages link to the README section it adds.Changes
titleandbody(the title is the passage's first paragraph, where a blank line ends one and a heading is one of its own, without leading list or quotation markers, a permalink mark or a gap before closing punctuation) and one on field kinds andoriginal_values. Under What to know, the upgrade step and what the first run does.titleandbodylisted as read only under What goes back, and a link to the upgrade section from the schema bullet.Testing
pnpm testpasses (39 files, 709 tests), including the content lint and the link check.Notes for reviewers
A light review is enough: two catalog pages, with every fact taken from the connector change.
Checklist