Repository navigation
docs(run): say what MAPP sends and where its switch is - #692
Merged
Merged
Conversation
aicayzer
commented
Oct 29, 2026
aicayzer
left a comment
aicayzer
left a comment
Contributor
Author
There was a problem hiding this comment.
Review: ready to merge
Summary. Says what MAPP sends, that only builds WithMarfa makes carry a destination, and where the switch is; reviewed with withmarfa/mapp#249.
First draft: 4/5. No blocking finding; the reviewer added missing report kinds and corrected how launch times are described, in 2ee365c.
Checked.
- True: every listed report and the never-sent list against MAPP's
Telemetry+Reports.swiftandReporting.
Reviewed by withmarfa-reviewer on Claude. This review may contain mistakes.
aicayzer
force-pushed
the
155/mapp-reports
branch
from
October 29, 2026 22:14
2ee365c to
898fbf7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds "What MAPP sends" to Send telemetry: the errors and events MAPP reports, that only a build WithMarfa made carries a destination, and the Send Error Reports switch (Settings, Library, on by default).
Based on #691 (branch 155/telemetry), which adds the "What apps send" section this extends; retarget to main once #691 merges.
Checked: pnpm build and pnpm test pass. pnpm types:check reports 6 errors, all in src/status, a folder this change does not touch.