Repository navigation
refactor: redesign Console log rows - #163
Open
MaxMichel2 wants to merge 1 commit into
Open
MaxMichel2 wants to merge 1 commit into
MaxMichel2 wants to merge 1 commit into
Conversation
Add expandable, selectable log rows, newest-first inspection and persistent case-insensitive exclusion rules without dropping captured history. Keep module screens internal and register their content through DevView. Fix collector lifetime, idle native cancellation and Analytics return anchors. Validation: Console 29 host and 21 Android device tests; Analytics 12 host and 15 device tests; core 19 device tests; 15 Konsist tests; sample debug build, Detekt and API generation passed. iOS regression lint passed; Apple compilation/runtime remains for the 60-minute macOS CI job.
| visibleLevels = LogLevel.entries.map { it.name } | ||
| onNoiseChange(ConsoleNoiseChange.DisableAll) | ||
| } | ||
| val listState = rememberLazyListState() |
There was a problem hiding this comment.
ConsoleScreen restores a row number, not the inspected log’s key. If following is paused and logs arrive between saving and restoring the screen, the newest-first order shifts existing rows. The saved number then points to a different log. The follow effect does not correct it because following is false.
Save the visible row’s key and offset, then find its current index on restore, as AnalyticsScreen does. Add a restoration test with arrivals between save and restore.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is PR D, based on
feat/analytics-event-detailand following PR #161. It describes only this layer, not the inherited UI-kit, FeatureFlip or Analytics-detail work. Merge order: #157 → #159 → #160 → #161 → this PR.setRequestedFrameRateandsetFrameRateCategory. Hosts can append, replace or omit defaults. Match case-insensitive substrings in tag/message without dropping captured history. Device additions, removals and disabled rules survive restart and merge new defaults without duplicates. Clear disables rules; Reset restores current host defaults. Loading/saving errors keep saved preferences intact and offer Retry.Validation
Executed successfully on this layer:
detektFull; explicit iOS regression-test Detekt; API signature generation. Normal Gitleaks and Detekt commit hooks passed.Pending / limits: Apple compilation and the new iOS runtime regression require macOS CI; Windows lint is not an Apple execution pass. Existing Detekt type-analysis warnings remain. Full TalkBack, keyboard and enlarged-font validation is not claimed. The known sample light-status-bar contrast and user-approved FAB placement are unchanged. Native trace grouping, streaming UTF-8/partial-write handling and cancellation of a stalled original iOS tee destination remain deferred. TimeCapsule, remaining NetworkMock redesign, sample polish and the final whole-UI delivery gate are deferred at the requested stop after PR D.
The PR appears safe to merge, with a non-blocking Console scroll-restoration issue.
Findings
Summary
This PR replaces Console cards with newest-first expandable rows and adds saved noise exclusions.
Diagram
%%{init: {'theme': 'neutral'}}%% flowchart LR Native[Native capture] --> Record[ConsoleLogger.log] Manual[Host logging] --> Record Record --> Queue[Bounded queue] Queue --> Collector[Single collector] Collector --> History[Read-only history] History --> Filters[Search, levels and noise rules] Preferences[Saved noise edits] --> Filters Filters --> Rows[Newest-first expandable rows]Reviews (1) · Last reviewed commit: ":sparkles: Redesign Console rows and per..." · Reviewed by Greptile