Repository navigation
Install Ghostscript only for packages that need it - #315
Merged
Merged
Conversation
Only scenarios tagged @require-bin-gs need Ghostscript, for Imagick to render PDFs. The runner images no longer ship it, so every Linux Behat leg spent 15-30s on apt-get for nothing in all packages but media-command. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ghostscript is now installed only when the package has a scenario tagged
@require-bin-gs. The check is agrepoverfeatures/right after checkout, and it gates the Linux, macOS and Windows installs.The
ubuntu-22.04image no longer ships Ghostscript, so the "already installed" shortcut from #274 never fires. Every Linux Behat job runsapt-get update && apt-get install ghostscript. In wp-cli/wp-cli that took 14–31 s per job (median 19 s), about 15 runner-minutes per run, for a package none of its tests use. Only media-command's PDF scenarios need it, for Imagick.Merge after wp-cli/media-command#273, which adds the tag. Until then media-command would lose Ghostscript, and its seven PDF scenarios would fail.
Testing
gswin64c, so@require-bin-gsskips those scenarios there. The macOS leg fails onmainevery night with the same seven scenarios even though Ghostscript is installed; this PR doesn't change that.🤖 Generated with Claude Code