Repository navigation
Ci/cp315 manylinux2014 lxml static - #432
Merged
Merged
Conversation
lxml 6.1.3 ships no cp315 manylinux2014_x86_64 wheel, so pip falls back to the sdist, which fails without libxml2/libxslt dev packages. For this combination only, build lxml with STATIC_DEPS using the same libxml2 and libxslt versions xmlsec links. Remove once lxml publishes the wheel.
Every workflow ran on both push and pull_request, so each push to a branch with an open PR started every workflow twice. The concurrency group is keyed on github.ref, which differs between the two events (refs/heads/<branch> vs refs/pull/<N>/merge), so the duplicates never cancelled each other. Restricting push to master leaves PR branches covered by pull_request alone.
libiconv 1.19's po/Makefile uses the '!=' shell assignment, which needs GNU make >= 4.0. CentOS 7 ships make 3.82, so all manylinux2014 builds fail with 'missing separator'. Install devtoolset-10-make, which is already first on the image's PATH.
lxml's static build doesn't add -fPIC on Linux, so linking the static libiconv/libxslt into the etree extension fails with R_X86_64_32 relocation errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.