Repository navigation
[PWGHF] candidateCreatorXicToXiPiPi, candidateSelectorXicToXiPiPi: fixed bug caused by missing condition - #18657
Merged
Merged
Conversation
hero-seo
requested review from
NicoleBastid,
alibuild,
apalasciano,
deepathoms,
fcatalan92,
fcolamar,
fgrosa,
gluparel,
hahassan7,
jpxrk,
mfaggin,
mmazzilli,
singhra1994,
stefanopolitano,
vkucera,
xinyepeng and
zhangbiao-phy
as code owners
November 9, 2026 10:30
github-actions
Bot
changed the title
Collaborator
|
@hero-seo the PR title does not specify the location. Please follow the contribution guidelines and add the file name in the PR title. See https://aliceo2group.github.io/analysis-framework/docs/gettingstarted/contributingtocode.html#pull-requests |
|
O2 linter results: ❌ 0 errors, |
hero-seo
changed the title
Contributor
Author
Hi @vkucera, I've added the file name in the PR title. I'll be more careful next time. |
fcatalan92
approved these changes
Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in the
candidateCreatorXicToXiPiPi,candidateSelectorXicToXiPiPicaused by a missingfillMc(QA)Histogramscondition.The histogram was created only when
fillMc(QA)Histogramswas true, but it was filled unconditionally, causing the task to crash whenfillMc(QA)Histogramswas set tofalse.To fix this issue, I've added the condition to prevent the crash
Thanks to @lubynets for pointing this out.