Repository navigation
core: Pin fixtures and tutorials to stable v32.1 - #164
Conversation
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Retain the tested package qualification workflow, explicit GH_REPO, prerelease classification and stable-publication guard from the proposed reduction. Remove RC-specific release integration and duplicate source checks; #207 tracks stable Core qualification and #164 its binary pin. Keep #52 on its existing native-stack base because GitHub rejects base retargeting while it is part of a stack. This replacement retains only the three intended release-file changes and does not carry unrelated integration-base changes into the PR. Build, isolated wheel/sdist checks, Twine, focused Ruff, metadata cases, source-CI refusal, hash-tampering rejection and mocked release creation passed on Linux Python 3.14. No actual release publication was performed. Refs #5, #52, #207.
BenWestgate
left a comment
BenWestgate
left a comment
There was a problem hiding this comment.
AI-assisted current-head review (dcb612b): blocked by upstream release change. Bitcoin Core's release maintainer confirmed that 32.0 binaries will never be published; 32.1 binaries were released instead (bitcoin/bitcoin#35122, Oct 26–28). The pinned bitcoin-32.0 fixture archive/URL in this diff therefore cannot pass. Retarget the fixture and versioned tutorial links to 32.1, independently verify the new archive digest/signatures, and run the Core regtest fixture before marking ready. No code/security ACK or merge yet.
Replace the 32.0rc2 fixture archive and RC tutorial links with the published stable 32.1 release. Upstream canceled binary publication for the tagged 32.0 release, so its archive URL cannot be qualified. Pin both previously moving offline-signing links to the same released tag. The Linux archive SHA256 agrees with the valid signed fanquake and achow101 build attestations in bitcoin-core/guix.sigs at fdc0f9635ca5bee7dd46c51f3bcf3afca83b2d5d. Verified the downloaded official archive against that digest and the official signed checksum file. Validation: tools/bitcoin_core_regtest.py passed against the authenticated stable binaries and reported /Satoshi:32.1.0/. Both versioned tutorial files exist, and git diff --check passes. Runtime source and tests are unchanged. Refs #164.
dcb612b to
03fe921
Compare
BenWestgate
changed the title
|
Addressed the upstream-release blocker in |
Address peer feedback on #164 by using the maintained upstream master tutorials for offline signing and multisig. Keep the Bitcoin Core v32.1 executable archive and checksum pinned. The upstream documentation links were verified. No runtime code or Core fixture checks changed.
Document the reviewer preference established in #164: link upstream tutorials on master, while pinning release-specific references, binaries, checksums, and reproducible fixtures. Documentation-only guidance. Checked target-branch policy, exact insertion and diff; no runtime behavior changes.
Replace the 32.0rc2 fixture binary with published stable Core 32.1. Per peer feedback, link the offline-signing and multisig tutorials to Bitcoin Core's maintained
masterdocumentation rather than a frozen release copy. The release maintainer confirmed that tagged 32.0 will have no binaries, so waiting on that archive cannot complete the stable transition.The official Linux archive SHA256 is
61545c17c3120fb7412f896d248b11993af04ec8817aad3649c55b2afb044963. It matches the official signed checksum file and two cryptographically verified build attestations: fanquake, achow101. Signatures were verified in an isolated GPG home with their published builder keys; independent key ownership verification is not claimed.Validation:
PYTHONPATH=src python3 tools/bitcoin_core_regtest.pywith the authenticated binaries in isolated temporary regtest state:{"bitcoin_core": "/Satoshi:32.1.0/", "status": "pass"}. This covers frozen fingerprints, descriptor setup/relocking, full and timestamped restore rescans, and signing/broadcast.mastertutorial files exist. Commit00c824fupdates only documentation links and surrounding wording; the authenticated Core fixture is unchanged.CONTRIBUTING.mdguidance on linking maintained upstream tutorials tomasterwhile retaining immutable version-specific fixture and checksum pins. Commit7883b5c; documentation-only diff reviewed.03fe921, including the Core fixture job, Python matrix and CodeQL. New-head checks run separately; the previously reported 24 passing checks apply to03fe921.Four files changed (the Core workflow, two guide files, and
CONTRIBUTING.md); runtime source and tests are unchanged. The Core 32 minimum and its existing tests remain necessary. Bails' matching RC override removal has already merged as BenWestgate/Bails#356.