Skip to content

core: Pin fixtures and tutorials to stable v32.1 #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BenWestgate merged 3 commits into from
Nov 10, 2026
Merged

core: Pin fixtures and tutorials to stable v32.1 #164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
03fe921
core: Pin fixtures and tutorials to stable v32.1
BenWestgate Oct 22, 2026
00c824f
docs: Follow upstream Core tutorials
BenWestgate Nov 9, 2026
7883b5c
docs: Prefer maintained upstream tutorial links
BenWestgate Nov 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/bitcoin-core-fixtures.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@ permissions:
contents: read

env:
BITCOIN_CORE_ARCHIVE: bitcoin-32.0rc2-x86_64-linux-gnu.tar.gz
BITCOIN_CORE_SHA256: 0255103718033e6aee15fa944717fc277e047b845bff1e7408af0ea732d8d0c1
BITCOIN_CORE_URL: https://bitcoincore.org/bin/bitcoin-core-32.0/test.rc2
BITCOIN_CORE_ARCHIVE: bitcoin-32.1-x86_64-linux-gnu.tar.gz
BITCOIN_CORE_SHA256: 61545c17c3120fb7412f896d248b11993af04ec8817aad3649c55b2afb044963
BITCOIN_CORE_URL: https://bitcoincore.org/bin/bitcoin-core-32.1

jobs:
verify:
Expand All @@ -41,7 +41,7 @@ jobs:
env:
PYTHONPATH: ${{ github.workspace }}/src
run: |
core="$RUNNER_TEMP/bitcoin-32.0rc2/bin"
core="$RUNNER_TEMP/bitcoin-32.1/bin"
"$core/bitcoind" --version | head -1
python tools/bitcoin_core_regtest.py \
--bitcoind "$core/bitcoind" \
Expand Down
12 changes: 12 additions & 0 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,18 @@ any users mentioned in the description will be annoyingly notified each time a
fork copies the merge. Instead, make any username mentions in a subsequent
comment to the PR.

### Links to Upstream Documentation

Link to maintained upstream tutorials and user guides on their `master` branch
rather than pinning them to a release tag. For example, link Bitcoin Core's
offline-signing and multisig tutorials on `master` so readers see updated
instructions. Check that the guidance still applies to supported software.

Use a tag or commit link when documenting version-specific behavior or
preserving historical/auditable evidence. Keep executable downloads, checksums,
dependencies, and test fixtures pinned and independently verified; live
links to documentation must not weaken those reproducibility requirements.

### Work in Progress Changes and Requests for Comments

If a pull request is not to be considered for merging (yet), please
Expand Down
8 changes: 4 additions & 4 deletions docs/developer/api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -653,10 +653,10 @@ xprv through `bitcoin-cli -stdin`, asks Core to create account-0 descriptors,
and relocks an encrypted destination after success, failure, or
interruption. It never handles a passphrase.

For offline signing/watch-only and multisig workflows, use Bitcoin Core v32's
maintained procedures. Until the final v32 release, see the versioned
[offline-signing tutorial](https://github.com/bitcoin/bitcoin/blob/v32.0rc1/doc/offline-signing-tutorial.md)
and [multisig tutorial](https://github.com/bitcoin/bitcoin/blob/v32.0rc1/doc/multisig-tutorial.md).
For offline signing/watch-only and multisig workflows, follow Bitcoin Core's
maintained procedures:
[offline-signing tutorial](https://github.com/bitcoin/bitcoin/blob/master/doc/offline-signing-tutorial.md)
and [multisig tutorial](https://github.com/bitcoin/bitcoin/blob/master/doc/multisig-tutorial.md).
The direct `ms32 xprv` primitive remains top-level and carries an explicit
secret-root warning.

Expand Down
6 changes: 3 additions & 3 deletions docs/user/guide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ On the offline signer, create an empty encrypted descriptor wallet with private
keys enabled and run `ms32 wallet`. Keep that computer disconnected from every
network while recovery text or signing keys are present.

After the signer is restored, follow Bitcoin Core v32's maintained
After the signer is restored, follow Bitcoin Core's maintained
[offline-signing tutorial](https://github.com/bitcoin/bitcoin/blob/master/doc/offline-signing-tutorial.md).
That workflow owns the watch-only export/import and PSBT transport steps. In
Bitcoin Core v32, `exportwatchonlywallet` creates the watch-only wallet file and
Expand Down Expand Up @@ -263,8 +263,8 @@ results disagree, or the wallet is multisig or nonstandard.
### Multisig cosigner recovery

Restore the cosigner's private Bitcoin Core wallet with `ms32 wallet`, then
follow Bitcoin Core v32's maintained
[multisig tutorial](https://github.com/bitcoin/bitcoin/blob/v32.0rc1/doc/multisig-tutorial.md).
follow Bitcoin Core's maintained
[multisig tutorial](https://github.com/bitcoin/bitcoin/blob/master/doc/multisig-tutorial.md).

### Card maintenance and damaged writing

Expand Down
Loading