Repository navigation
fix: duplicate empty kwargs - #1720
Open
oliwenmandiamond wants to merge 15 commits into
Open
oliwenmandiamond wants to merge 15 commits into
oliwenmandiamond wants to merge 15 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1720 +/- ##
==========================================
+ Coverage 96.46% 96.49% +0.03%
==========================================
Files 49 49
Lines 3791 3799 +8
==========================================
+ Hits 3657 3666 +9
+ Misses 134 133 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
oliwenmandiamond
changed the title
oliwenmandiamond
marked this pull request as ready for review
October 26, 2026 10:45
tpoliaw
requested changes
Oct 26, 2026
Co-authored-by: Peter Holloway <peter.holloway@diamond.ac.uk>
Contributor
Author
|
@tpoliaw I've had another go at this. I've tried to make it easier to understand the intention and the flaws with previous implementation via doc strings and tests. Please have another review and let me know what you think |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1719