Repository navigation
Example results in the Viewer, one per analysis, named after it - #152
Open
t0mdavid-m wants to merge 18 commits into
Open
t0mdavid-m wants to merge 18 commits into
t0mdavid-m wants to merge 18 commits into
Conversation
Keep the protein mix LC-MS run (deconvolution only) and the native GapA spectrum (identified, Native preset), named after the analysis they show. Drop the other native spectra and the antibody spectrum, which open the same layout, and the stored results of the former FLASHDeconv and FLASHTnT workflows, which the combined Viewer no longer reads. example-data/build_examples.py rebuilds the results into the demo workspace's shared cache. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FkEGepokDF4C9QwY1TkrQ5
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FkEGepokDF4C9QwY1TkrQ5
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FkEGepokDF4C9QwY1TkrQ5
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FkEGepokDF4C9QwY1TkrQ5
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FkEGepokDF4C9QwY1TkrQ5
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FkEGepokDF4C9QwY1TkrQ5
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FkEGepokDF4C9QwY1TkrQ5
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FkEGepokDF4C9QwY1TkrQ5
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FkEGepokDF4C9QwY1TkrQ5
The build script downloads four SpikeIn runs from MassIVE, keeps a 4-minute retention-time window and runs them identified with label-free quantification. A comparison with a display name of its own keeps it in the Viewer's experiment list. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FkEGepokDF4C9QwY1TkrQ5
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FkEGepokDF4C9QwY1TkrQ5
The label-free comparison keeps its own tables, so the results of its other three runs are dropped from the demo cache. The SpikeIn runs are cut to 2.5 minutes. Together this takes the demo cache from 466 MB to roughly 170 MB. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FkEGepokDF4C9QwY1TkrQ5
…build job tests/test_examples.py checks that every example is named after what it shows, opens its sample type's layout, and that the label-free example compares two conditions over four runs. The lysate spectra carry precursor charges, so the PrSM overview test now expects them only to be missing on the native example. The temporary job that built the examples is removed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FkEGepokDF4C9QwY1TkrQ5
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FkEGepokDF4C9QwY1TkrQ5
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FkEGepokDF4C9QwY1TkrQ5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Tom · project thread
What changes for users
A new workspace now opens the Viewer with ready results, one per default layout the example data covers, each named after what it shows:
Deconvolution-only_ProteinMix_LC-MS.mzMLNative-identified_GapA_HCD.mzML+ example databaseLabel-free_SpikeIn-1x_R1.mzML+ example databaseLabel-free_SpikeIn-*.mzMLrunsUntil now the demo workspace held its results in the folders of the former FLASHDeconv and FLASHTnT workflows, which the combined Viewer does not read, so a new workspace showed "No results to show yet".
quant_view.comparison_names).How the results are made
example-data/build_examples.pyruns the Top-down analysis on each example the way the Run page does (deconvolution only; Native preset; Lysate preset with label-free quantification and an experimental design). It stores the results in the demo workspace's shared cache under fixed ids (example_deconvolution,example_native_identified,example_lysate_identified,example_label_free) and sets their display names. A missing SpikeIn input is downloaded from MassIVE and trimmed. The script needs the TOPP tools. It ran inghcr.io/openms/flashapp:latestthrough a temporary workflow on this branch, which has been removed again (no change under.github/in the diff).Merge with squash. One intermediate commit on this branch holds a larger cache (466 MB) that was then reduced. A merge commit would keep it in the history of
develop.Tests
tests/test_examples.py:pytest tests/passes locally (601 passed).Not covered by an example
TMT/iTRAQ (with or without identification): no small public top-down isobaric dataset was found. This is left for a follow-up.
Screenshots
choose experiment lists the four examples:

Example: lysate, identified:

Example: label-free comparison:

Example: native, identified (GapA):

Example: deconvolution only:

Upload page:

Videos: lysate-and-label-free-in-viewer.mp4, examples-in-viewer.mp4
The media files were added and removed again in separate commits; they are not in the diff.
🤖 Generated with Claude Code
https://claude.ai/code/session_01FkEGepokDF4C9QwY1TkrQ5