Skip to content

fix: preserve numeric percentages in company CSV exports - #1452

Closed
tannerlinsley wants to merge 15 commits into
mainfrom
taren/csv-growth-percentages
Closed

tannerlinsley wants to merge 15 commits into
mainfrom
taren/csv-growth-percentages

Conversation

@tannerlinsley

Copy link
Copy Markdown
Member

The company CSV export was adding a literal apostrophe to generated changes such as +50% and -50%. Keep these calculated percentages intact while continuing to escape company names and other source text.

Targets #1446.

AI review notes:
A focused source-level check exercised the actual growth calculation and label with d3 CSV formatting and parsing. Positive, negative, zero, New, and N/A values passed, and a formula-like company name remained escaped. The previous expression produces the unwanted apostrophe. This was not a rendered browser test.
Full repository checks passed through normal commit hooks on base de47516. The parent has since advanced to c825c6f; the CSV component, calculation/escaping helpers, package manifest, and lockfile are unchanged. CI will validate the combined branch.

@changeset-bot

changeset-bot Bot commented Oct 30, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: dd6b626

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 39 seconds.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: dd21cd29-1e71-41d7-9dad-73566aba2483
Commits

Reviewing files that changed from the base of the PR and between 8bd5925 and dd6b626.

Files selected for processing: 52
  • docs/live-visitors.md
  • docs/visitor-chat.md
  • drizzle/migrations/0043_visitor_chat.sql
  • drizzle/migrations/meta/0043_snapshot.json
  • drizzle/migrations/meta/_journal.json
  • harness-tests/pending-runtime/visitor-chat.test.ts
  • src/components/ProductScarf.tsx
  • src/components/admin/CompanyFacetFilter.tsx
  • src/components/admin/LiveCompanyCharts.tsx
  • src/components/admin/LiveCompanySessions.tsx
  • src/components/admin/LiveVisitors.tsx
  • src/components/visitor-chat/AdminVisitorChats.css
  • src/components/visitor-chat/AdminVisitorChats.tsx
  • src/components/visitor-chat/VisitorChat.css
  • src/components/visitor-chat/VisitorChat.tsx
  • src/db/schema.ts
  • src/instrument.server.mjs
  • src/routes/__root.tsx
  • src/routes/admin/live.tsx
  • src/routes/index.tsx
  • src/server.ts
  • src/server/runtime/blob-storage.server.ts
  • src/server/runtime/host.server.ts
  • src/server/scheduled.server.ts
  • src/styles/app.css
  • src/utils/analytics/live-browser.ts
  • src/utils/analytics/live-dashboard.ts
  • src/utils/analytics/live.functions.ts
  • src/utils/analytics/live.server.ts
  • src/utils/analytics/live.ts
  • src/utils/analytics/scarf-history.server.ts
  • src/utils/analytics/scarf-history.ts
  • src/utils/analytics/scarf-lookup.server.ts
  • src/utils/analytics/scarf-pixels.ts
  • src/utils/analytics/scarf.ts
  • src/utils/sentry-redaction.ts
  • src/utils/visitor-chat/admin.functions.ts
  • src/utils/visitor-chat/auth.server.ts
  • src/utils/visitor-chat/bootstrap.ts
  • src/utils/visitor-chat/contract.ts
  • src/utils/visitor-chat/store.server.ts
  • src/utils/visitor-chat/visitor.server.ts
  • tests/live-company-tools.test.ts
  • tests/live-intake.test.ts
  • tests/live-lookup-limit.test.ts
  • tests/live-presence.test.ts
  • tests/live-scheduled.test.ts
  • tests/scarf-history.test.ts
  • tests/visitor-chat-css.test.ts
  • tests/visitor-chat.test.ts
  • vite.config.ts
  • wrangler.jsonc
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
tanstack-com dd6b626 Commit Preview URL

Branch Preview URL
Oct 30 2026, 12:25 AM

Base automatically changed from taren/visitor-chat to main October 30, 2026 00:28
@tannerlinsley
tannerlinsley requested a review from a team October 30, 2026 00:28
@tannerlinsley

Copy link
Copy Markdown
Member Author

Replaced by #1454, which carries the same one-line CSV fix onto main after the parent was squash-merged. Closing this copy so the fix can continue there without the old stack conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant